Union/ProjectLighthouse
1
0
Fork 0
mirror of https://github.com/LBPUnion/ProjectLighthouse.git synced 2025-08-01 09:48:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Refactor serialization system (#702)

Browse source 
* Initial work for serialization refactor

* Experiment with new naming conventions

* Mostly implement user and slot serialization.
Still needs to be fine tuned to match original implementation
Many things are left in a broken state like website features/api endpoints/lbp3 categories

* Fix release building

* Migrate scores, reviews, and more to new serialization system.
Many things are still broken but progress is steadily being made

* Fix Api responses and migrate serialization for most types

* Make serialization better and fix bugs
Fix recursive PrepareSerialization when recursive item is set during root item's PrepareSerialization, items, should be properly indexed in order but it's only tested to 1 level of recursion

* Fix review serialization

* Fix user serialization producing malformed SQL query

* Remove DefaultIfEmpty query

* MariaDB doesn't like double nested queries

* Fix LBP1 tag counter

* Implement lbp3 categories and add better deserialization handling

* Implement expression tree caching to speed up reflection and write new serializer tests

* Remove Game column from UserEntity and rename DatabaseContextModelSnapshot.cs back to DatabaseModelSnapshot.cs

* Make UserEntity username not required

* Fix recursive serialization of lists and add relevant unit tests

* Actually commit the migration

* Fix LocationTests to use new deserialization class

* Fix comments not serializing the right author username

* Replace all occurrences of StatusCode with their respective ASP.NET named result
instead of StatusCode(403) everything is now in the form of Forbid()

* Fix SlotBase.ConvertToEntity and LocationTests

* Fix compilation error

* Give Location a default value in GameUserSlot and GameUser

* Reimplement stubbed website functions

* Convert grief reports to new serialization system

* Update DatabaseModelSnapshot and bump dotnet tool version

* Remove unused directives

* Fix broken type reference

* Fix rated comments on website

* Don't include banned users in website comments

* Optimize score submission

* Fix slot id calculating in in-game comment posting

* Move serialization interfaces to types folder and add more documentation

* Allow uploading of versus scores
This commit is contained in:
Josh 2023-03-27 19:39:54 -05:00 • committed by GitHub
commit 329ab66043
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
248 changed files with 4993 additions and 2896 deletions
Download patch file Download diff file Expand all files Collapse all files

22
ProjectLighthouse.Servers.Website/Pages/UserPage.cshtml.cs
View file

@ -14,7 +14,7 @@ namespace LBPUnion.ProjectLighthouse.Servers.Website.Pages;
public class UserPage : BaseLayout
{
public List<Comment>? Comments;
public Dictionary<CommentEntity, RatedCommentEntity?> Comments = new();
public bool CommentsEnabled;
@ -22,13 +22,13 @@ public class UserPage : BaseLayout
public bool IsProfileUserBlocked;
public List<Photo>? Photos;
public List<Slot>? Slots;
public List<PhotoEntity>? Photos;
public List<SlotEntity>? Slots;
public List<Slot>? HeartedSlots;
public List<Slot>? QueuedSlots;
public List<SlotEntity>? HeartedSlots;
public List<SlotEntity>? QueuedSlots;
public User? ProfileUser;
public UserEntity? ProfileUser;
public UserPage(DatabaseContext database) : base(database)
{}
@ -105,21 +105,21 @@ public class UserPage : BaseLayout
.Where(p => p.TargetId == userId && p.Type == CommentType.Profile)
.Where(p => !blockedUsers.Contains(p.PosterUserId))
.Take(50)
.ToListAsync();
.ToDictionaryAsync(c => c, _ => (RatedCommentEntity?) null);
}
else
{
this.Comments = new List<Comment>();
this.Comments = new Dictionary<CommentEntity, RatedCommentEntity?>();
}
if (this.User == null) return this.Page();
foreach (Comment c in this.Comments)
foreach (KeyValuePair<CommentEntity, RatedCommentEntity?> kvp in this.Comments)
{
Reaction? reaction = await this.Database.Reactions.Where(r => r.TargetId == c.TargetId)
RatedCommentEntity? reaction = await this.Database.RatedComments.Where(r => r.CommentId == kvp.Key.CommentId)
.Where(r => r.UserId == this.User.UserId)
.FirstOrDefaultAsync();
if (reaction != null) c.YourThumb = reaction.Rating;
this.Comments[kvp.Key] = reaction;
}
this.IsProfileUserHearted = await this.Database.HeartedProfiles