Union/ProjectLighthouse
1
0
Fork 0
mirror of https://github.com/LBPUnion/ProjectLighthouse.git synced 2025-08-09 05:18:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Refactor serialization system (#702)

Browse source 
* Initial work for serialization refactor

* Experiment with new naming conventions

* Mostly implement user and slot serialization.
Still needs to be fine tuned to match original implementation
Many things are left in a broken state like website features/api endpoints/lbp3 categories

* Fix release building

* Migrate scores, reviews, and more to new serialization system.
Many things are still broken but progress is steadily being made

* Fix Api responses and migrate serialization for most types

* Make serialization better and fix bugs
Fix recursive PrepareSerialization when recursive item is set during root item's PrepareSerialization, items, should be properly indexed in order but it's only tested to 1 level of recursion

* Fix review serialization

* Fix user serialization producing malformed SQL query

* Remove DefaultIfEmpty query

* MariaDB doesn't like double nested queries

* Fix LBP1 tag counter

* Implement lbp3 categories and add better deserialization handling

* Implement expression tree caching to speed up reflection and write new serializer tests

* Remove Game column from UserEntity and rename DatabaseContextModelSnapshot.cs back to DatabaseModelSnapshot.cs

* Make UserEntity username not required

* Fix recursive serialization of lists and add relevant unit tests

* Actually commit the migration

* Fix LocationTests to use new deserialization class

* Fix comments not serializing the right author username

* Replace all occurrences of StatusCode with their respective ASP.NET named result
instead of StatusCode(403) everything is now in the form of Forbid()

* Fix SlotBase.ConvertToEntity and LocationTests

* Fix compilation error

* Give Location a default value in GameUserSlot and GameUser

* Reimplement stubbed website functions

* Convert grief reports to new serialization system

* Update DatabaseModelSnapshot and bump dotnet tool version

* Remove unused directives

* Fix broken type reference

* Fix rated comments on website

* Don't include banned users in website comments

* Optimize score submission

* Fix slot id calculating in in-game comment posting

* Move serialization interfaces to types folder and add more documentation

* Allow uploading of versus scores
This commit is contained in:
Josh 2023-03-27 19:39:54 -05:00 • committed by GitHub
commit 329ab66043
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
248 changed files with 4993 additions and 2896 deletions
Download patch file Download diff file Expand all files Collapse all files

19
ProjectLighthouse.Tests/Tests/LocationTests.cs
View file

@ -3,6 +3,7 @@ using System.Xml.Serialization;
using LBPUnion.ProjectLighthouse.Types.Entities.Level;
using LBPUnion.ProjectLighthouse.Types.Entities.Profile;
using LBPUnion.ProjectLighthouse.Types.Misc;
using LBPUnion.ProjectLighthouse.Types.Serialization;
using Xunit;
namespace LBPUnion.ProjectLighthouse.Tests;
@ -17,7 +18,7 @@ public class LocationTests
X = 1000,
Y = 5000,
};
User user = new()
UserEntity user = new()
{
Location = new Location
{
@ -38,7 +39,7 @@ public class LocationTests
X = 1000,
Y = 5000,
};
Slot slot = new()
SlotEntity slot = new()
{
Location = new Location
{
@ -54,28 +55,30 @@ public class LocationTests
[Fact]
public void ShouldReadLocationAfterDeserialization()
{
XmlSerializer deserializer = new(typeof(Slot));
XmlSerializer deserializer = new(typeof(GameUserSlot));
const string slotData = "<slot><name>test</name><resource>test</resource><location><x>4000</x><y>9000</y></location></slot>";
Slot? deserialized = (Slot?)deserializer.Deserialize(new StringReader(slotData));
GameUserSlot? deserialized = (GameUserSlot?)deserializer.Deserialize(new StringReader(slotData));
Assert.True(deserialized != null);
Assert.True(deserialized.Name == "test");
Assert.True(deserialized.Location.X == 4000);
Assert.True(deserialized.Location.Y == 9000);
Assert.True(deserialized.LocationPacked == 17_179_869_193_000);
SlotEntity entity = SlotBase.ConvertToEntity(deserialized);
Assert.True(entity.LocationPacked == 17_179_869_193_000);
}
[Fact]
public void ShouldDeserializeEmptyLocation()
{
XmlSerializer deserializer = new(typeof(Slot));
XmlSerializer deserializer = new(typeof(GameUserSlot));
const string slotData = "<slot><name>test</name></slot>";
Slot? deserialized = (Slot?)deserializer.Deserialize(new StringReader(slotData));
GameUserSlot? deserialized = (GameUserSlot?)deserializer.Deserialize(new StringReader(slotData));
Assert.True(deserialized != null);
Assert.True(deserialized.Name == "test");
Assert.True(deserialized.Location.X == 0);
Assert.True(deserialized.Location.Y == 0);
Assert.True(deserialized.LocationPacked == 0);
SlotEntity entity = SlotBase.ConvertToEntity(deserialized);
Assert.True(entity.LocationPacked == 0);
}
}