Union/ProjectLighthouse
1
0
Fork 0
mirror of https://github.com/LBPUnion/ProjectLighthouse.git synced 2025-08-09 13:28:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Log room cleanups better

Browse source
This commit is contained in:
jvyden 2022-06-17 20:40:52 -04:00
commit 638ee85e81
No known key found for this signature in database
GPG key ID: 18BCF2BE0262B278
1 changed files with 22 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

25
ProjectLighthouse/Match/Rooms/RoomHelper.cs
View file

@ -1,5 +1,6 @@
#nullable enable
using System.Collections.Generic;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using System.Threading.Tasks;
@ -194,8 +195,15 @@ public class RoomHelper
[SuppressMessage("ReSharper", "InvertIf")]
public static void CleanupRooms(int? hostId = null, Room? newRoom = null, Database? database = null)
{
#if DEBUG
Stopwatch stopwatch = new();
stopwatch.Start();
#endif
lock(RoomLock)
{
#if DEBUG
Logger.Debug($"Cleaning up rooms... (took {stopwatch.ElapsedMilliseconds}ms to get lock on {nameof(RoomLock)})", LogArea.Match);
#endif
int roomCountBeforeCleanup = Rooms.Count();
// Remove offline players from rooms
@ -233,10 +241,21 @@ public class RoomHelper
int roomCountAfterCleanup = Rooms.Count();
if (roomCountBeforeCleanup != roomCountAfterCleanup)
// Log the amount of rooms cleaned up.
// If we didnt clean any rooms, it's not useful to log in a
// production environment but it's still quite useful for debugging.
//
// So, we handle that case here:
int roomsCleanedUp = roomCountBeforeCleanup - roomCountAfterCleanup;
string logText = $"Cleaned up {roomsCleanedUp} rooms.";
if (roomsCleanedUp == 0)
{
Logger.Debug($"Cleaned up {roomCountBeforeCleanup - roomCountAfterCleanup} rooms.",
LogArea.Match);
Logger.Debug(logText, LogArea.Match);
}
else
{
Logger.Info(logText, LogArea.Match);
}
}
}