From bf2e36e8a484e263a1b457dafa472e002222c8ab Mon Sep 17 00:00:00 2001
From: koko <koko@drones.gay>
Date: Sat, 17 Jun 2023 00:12:46 -0400
Subject: [PATCH] Handle edge case bug in banned page (#801)

---
 .../Pages/Login/BannedUserPage.cshtml         | 34 +++++++++++--------
 .../Pages/Login/BannedUserPage.cshtml.cs      |  6 ++--
 2 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/ProjectLighthouse.Servers.Website/Pages/Login/BannedUserPage.cshtml b/ProjectLighthouse.Servers.Website/Pages/Login/BannedUserPage.cshtml
index 881d00e6..0607ec48 100644
--- a/ProjectLighthouse.Servers.Website/Pages/Login/BannedUserPage.cshtml
+++ b/ProjectLighthouse.Servers.Website/Pages/Login/BannedUserPage.cshtml
@@ -17,16 +17,19 @@
     </p>         
    
     <p>
-        <span>
-            @if (Model.ModCase.ExpiresAt != null)
-            {
-                @Model.Translate(ModerationStrings.SuspensionExpiration, TimeZoneInfo.ConvertTime(Model.ModCase.ExpiresAt.Value, timeZoneInfo).ToString("M/d/yyyy @ h:mm tt"))
-            }
-            else
-            {
-                @Model.Translate(ModerationStrings.SuspensionExpiration, Model.Translate(ModerationStrings.DoesNotExpire))
-            }
-        </span>
+        @if (Model.ModCase != null)
+        {
+            <span>
+                @if (Model.ModCase.ExpiresAt != null)
+                {
+                    @Model.Translate(ModerationStrings.SuspensionExpiration, TimeZoneInfo.ConvertTime(Model.ModCase.ExpiresAt.Value, timeZoneInfo).ToString("M/d/yyyy @ h:mm tt"))
+                }
+                else
+                {
+                    @Model.Translate(ModerationStrings.SuspensionExpiration, Model.Translate(ModerationStrings.DoesNotExpire))
+                }
+            </span>    
+        }
 
         <ul>
             <li>@Model.Translate(ModerationStrings.LbpOnlineMultiplayer)</li>
@@ -36,10 +39,13 @@
         </ul>
     </p>
     
-    <p>
-        @Model.Translate(ModerationStrings.SuspensionReason, Model.ModCase.Reason)
-    </p> 
-    
+    @if (Model.ModCase != null)
+    {
+        <p>
+            @Model.Translate(ModerationStrings.SuspensionReason, Model.ModCase.Reason)
+        </p>     
+    }
+
     <p>
         @Model.Translate(ModerationStrings.SuspensionCircumventWarning)
     </p>
diff --git a/ProjectLighthouse.Servers.Website/Pages/Login/BannedUserPage.cshtml.cs b/ProjectLighthouse.Servers.Website/Pages/Login/BannedUserPage.cshtml.cs
index d951591e..4ddcbb1f 100644
--- a/ProjectLighthouse.Servers.Website/Pages/Login/BannedUserPage.cshtml.cs
+++ b/ProjectLighthouse.Servers.Website/Pages/Login/BannedUserPage.cshtml.cs
@@ -1,8 +1,10 @@
 using JetBrains.Annotations;
 using LBPUnion.ProjectLighthouse.Database;
+using LBPUnion.ProjectLighthouse.Logging;
 using LBPUnion.ProjectLighthouse.Servers.Website.Pages.Layouts;
 using LBPUnion.ProjectLighthouse.Types.Entities.Moderation;
 using LBPUnion.ProjectLighthouse.Types.Entities.Profile;
+using LBPUnion.ProjectLighthouse.Types.Logging;
 using LBPUnion.ProjectLighthouse.Types.Moderation.Cases;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.EntityFrameworkCore;
@@ -14,7 +16,7 @@ public class BannedUserPage : BaseLayout
     public BannedUserPage(DatabaseContext database) : base(database)
     { }
 
-    public ModerationCaseEntity ModCase = null!;
+    public ModerationCaseEntity? ModCase;
 
     [UsedImplicitly]
     public async Task<IActionResult> OnGet()
@@ -30,7 +32,7 @@ public class BannedUserPage : BaseLayout
             .Where(c => c.DismissedAt != null)
             .FirstOrDefaultAsync();
 
-        if (modCase == null) return this.Redirect("~/");
+        if (modCase == null) Logger.Warn($"User {user.UserId} is banned but has no mod case?", LogArea.Login);
 
         this.ModCase = modCase;