Union/ProjectLighthouse
1
0
Fork 0
mirror of https://github.com/LBPUnion/ProjectLighthouse.git synced 2025-08-21 09:49:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add rejected login logging

Browse source
This commit is contained in:
jvyden 2021-12-26 17:47:15 -05:00
commit d240a7480b
No known key found for this signature in database
GPG key ID: 18BCF2BE0262B278
1 changed files with 27 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

32
ProjectLighthouse/Controllers/LoginController.cs
View file

@ -41,10 +41,19 @@ namespace LBPUnion.ProjectLighthouse.Controllers
{ {
loginData = null; loginData = null;
} }
if (loginData == null) return this.BadRequest();
if (loginData == null)
{
Logger.Log("loginData was null, rejecting login", LoggerLevelLogin.Instance);
return this.BadRequest();
}
IPAddress? remoteIpAddress = this.HttpContext.Connection.RemoteIpAddress; IPAddress? remoteIpAddress = this.HttpContext.Connection.RemoteIpAddress;
if (remoteIpAddress == null) return this.StatusCode(403, ""); // 403 probably isnt the best status code for this, but whatever if (remoteIpAddress == null)
{
Logger.Log("unable to determine ip, rejecting login", LoggerLevelLogin.Instance);
return this.StatusCode(403, ""); // 403 probably isnt the best status code for this, but whatever
}
string ipAddress = remoteIpAddress.ToString(); string ipAddress = remoteIpAddress.ToString();
@ -56,11 +65,19 @@ namespace LBPUnion.ProjectLighthouse.Controllers
if (token == null) // If we cant find an existing token, try to generate a new one if (token == null) // If we cant find an existing token, try to generate a new one
{ {
token = await this.database.AuthenticateUser(loginData, ipAddress, titleId); token = await this.database.AuthenticateUser(loginData, ipAddress, titleId);
if (token == null) return this.StatusCode(403, ""); // If not, then 403. if (token == null)
{
Logger.Log("unable to find/generate a token, rejecting login", LoggerLevelLogin.Instance);
return this.StatusCode(403, ""); // If not, then 403.
}
} }
User? user = await this.database.UserFromGameToken(token, true); User? user = await this.database.UserFromGameToken(token, true);
if (user == null) return this.StatusCode(403, ""); if (user == null)
{
Logger.Log("unable to find a user from a token, rejecting login", LoggerLevelLogin.Instance);
return this.StatusCode(403, "");
}
if (ServerSettings.Instance.UseExternalAuth) if (ServerSettings.Instance.UseExternalAuth)
{ {
@ -75,6 +92,7 @@ namespace LBPUnion.ProjectLighthouse.Controllers
DeniedAuthenticationHelper.AddAttempt(ipAddressAndName); DeniedAuthenticationHelper.AddAttempt(ipAddressAndName);
await this.database.SaveChangesAsync(); await this.database.SaveChangesAsync();
Logger.Log("too many denied logins, rejecting login", LoggerLevelLogin.Instance);
return this.StatusCode(403, ""); return this.StatusCode(403, "");
} }
} }
@ -104,7 +122,11 @@ namespace LBPUnion.ProjectLighthouse.Controllers
await this.database.SaveChangesAsync(); await this.database.SaveChangesAsync();
if (!token.Approved) return this.StatusCode(403, ""); if (!token.Approved)
{
Logger.Log("token unapproved, rejecting login", LoggerLevelLogin.Instance);
return this.StatusCode(403, "");
}
Logger.Log($"Successfully logged in user {user.Username} as {token.GameVersion} client ({titleId})", LoggerLevelLogin.Instance); Logger.Log($"Successfully logged in user {user.Username} as {token.GameVersion} client ({titleId})", LoggerLevelLogin.Instance);
// After this point we are now considering this session as logged in. // After this point we are now considering this session as logged in.