From d2ec5504217c7d424c04c92a0aa5fe01ca5c1aca Mon Sep 17 00:00:00 2001
From: jvyden <jvyden@jvyden.xyz>
Date: Sat, 18 Dec 2021 15:43:16 -0500
Subject: [PATCH] Fix performance on photos page

---
 .../Pages/Partials/PhotoPartial.cshtml        | 26 +++++++++----------
 ProjectLighthouse/Types/PhotoSubject.cs       |  2 ++
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/ProjectLighthouse/Pages/Partials/PhotoPartial.cshtml b/ProjectLighthouse/Pages/Partials/PhotoPartial.cshtml
index 081a3bcc..761f63b8 100644
--- a/ProjectLighthouse/Pages/Partials/PhotoPartial.cshtml
+++ b/ProjectLighthouse/Pages/Partials/PhotoPartial.cshtml
@@ -1,14 +1,13 @@
 @using LBPUnion.ProjectLighthouse.Types
-
 @model LBPUnion.ProjectLighthouse.Types.Photo
 
 
-
 <div style="position: relative">
     <canvas class="hide-subjects" id="canvas-subjects-@Model.PhotoId" width="1920" height="1080"
-        style="position: absolute; transform: rotate(180deg)"></canvas>
+            style="position: absolute; transform: rotate(180deg)">
+    </canvas>
     <img id="game-image-@Model.PhotoId" src="/gameAssets/@Model.LargeHash"
-        style="width: 100%; height: auto; border-radius: .28571429rem;">
+         style="width: 100%; height: auto; border-radius: .28571429rem;">
 </div>
 <br>
 
@@ -31,14 +30,16 @@
     }
 </div>
 
+@{
+    PhotoSubject[] subjects = Model.Subjects.ToArray();
+    foreach (PhotoSubject subject in subjects) subject.Username = subject.User.Username;
+}
 
 <script>
     // render the page first so that image heights have been calculated
     window.addEventListener("load", function () {
-        var canvas = document.getElementById("canvas-subjects-@Model.PhotoId");
-
+        const canvas = document.getElementById("canvas-subjects-@Model.PhotoId");
         const hoverer = document.getElementById("hover-subjects-@Model.PhotoId");
-
         const image = document.getElementById("game-image-@Model.PhotoId");
 
         hoverer.addEventListener('mouseenter', function () {
@@ -47,10 +48,10 @@
         hoverer.addEventListener('mouseleave', function () {
             canvas.className = "photo-subjects hide-subjects";
         });
+        
+        const context = canvas.getContext('2d');
 
-        var context = canvas.getContext('2d');
-
-        const subjects = @Html.Raw(Json.Serialize(Model.Subjects.ToArray()));
+        const subjects = @Html.Raw(Json.Serialize(subjects.ToArray()));
 
         canvas.width = image.offsetWidth;
         canvas.height = image.clientHeight; // space for names to hang off
@@ -65,7 +66,6 @@
         const colours = ["#a5599f", "#477f84", "#5fa559", "#a5595f"];
 
         subjects.forEach((s, si) => {
-
             const colour = colours[si % 4];
 
             // Bounding box
@@ -92,7 +92,7 @@
             context.fillStyle = colour;
 
             // Text width/height for the label background
-            const tw = context.measureText(s.user.username).width;
+            const tw = context.measureText(s.username).width;
             const th = 24;
 
             // Check if the label will flow off the bottom of the frame
@@ -117,7 +117,7 @@
             // Draw text, rotated back upright (canvas draws rotated 180deg)
             context.fillStyle = "white";
             context.rotate(Math.PI);
-            context.fillText(s.user.username, lx, ly);
+            context.fillText(s.username, lx, ly);
 
             // reset transform
             context.setTransform(1, 0, 0, 1, 0, 0);
diff --git a/ProjectLighthouse/Types/PhotoSubject.cs b/ProjectLighthouse/Types/PhotoSubject.cs
index 99be0fb7..05144f33 100644
--- a/ProjectLighthouse/Types/PhotoSubject.cs
+++ b/ProjectLighthouse/Types/PhotoSubject.cs
@@ -1,6 +1,7 @@
 using System;
 using System.ComponentModel.DataAnnotations;
 using System.ComponentModel.DataAnnotations.Schema;
+using System.Text.Json.Serialization;
 using System.Xml.Serialization;
 using LBPUnion.ProjectLighthouse.Serialization;
 
@@ -20,6 +21,7 @@ namespace LBPUnion.ProjectLighthouse.Types
 
         [XmlIgnore]
         [ForeignKey(nameof(UserId))]
+        [JsonIgnore]
         public User User { get; set; }
 
         [NotMapped]