Union/UnionPatcher
1
0
Fork 0
mirror of https://github.com/LBPUnion/UnionPatcher.git synced 2025-08-03 06:38:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add comment explaining why length as byte is problematic

Browse source
This commit is contained in:
jvyden 2021-10-18 10:21:34 -04:00
commit 69280c1213
No known key found for this signature in database
GPG key ID: 18BCF2BE0262B278
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
UnionPatcher/Patcher.cs
View file

@ -23,7 +23,8 @@ namespace UnionPatcher {
using MemoryStream ms = new(data); using MemoryStream ms = new(data);
using BinaryWriter writer = new(ms); using BinaryWriter writer = new(ms);
// using writer.Write(string) writes the length as a byte beforehand which is problematic // using writer.Write(string) writes the length as a byte beforehand which is problematic because
// LBP uses null-terminated strings, not length-defined strings
byte[] serverUrlAsBytes = Encoding.ASCII.GetBytes(serverUrl); byte[] serverUrlAsBytes = Encoding.ASCII.GetBytes(serverUrl);
foreach(string url in ToBePatched) { foreach(string url in ToBePatched) {