ncm client: implement SubmissionPackageInstallTask

libraries/libstratosphere/include/stratosphere/ncm.hpp

@@ -34,5 +34,6 @@
 #include <stratosphere/ncm/ncm_package_install_task_base.hpp>
 #include <stratosphere/ncm/ncm_package_install_task.hpp>
 #include <stratosphere/ncm/ncm_package_system_update_task.hpp>
+#include <stratosphere/ncm/ncm_submission_package_install_task.hpp>
 #include <stratosphere/ncm/ncm_storage_id_utils.hpp>
 #include <stratosphere/ncm/ncm_api.hpp>

libraries/libstratosphere/include/stratosphere/ncm/ncm_submission_package_install_task.hpp

@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) 2019-2020 Adubbz, Atmosphère-NX
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#pragma once
+#include <stratosphere/fs/fs_file_storage.hpp>
+#include <stratosphere/ncm/ncm_package_install_task.hpp>
+
+namespace ams::ncm {
+
+    class SubmissionPackageInstallTask : public PackageInstallTask {
+        private:
+            class Impl;
+        private:
+            Impl *impl;
+        public:
+            SubmissionPackageInstallTask() { /* ... */ }
+            ~SubmissionPackageInstallTask();
+
+            Result Initialize(fs::FileHandle handle, StorageId storage_id, void *buffer, size_t buffer_size, bool ignore_ticket);
+    };
+
+}

libraries/libstratosphere/source/ncm/ncm_install_task_data.cpp

@@ -341,7 +341,7 @@ namespace ams::ncm {
         R_TRY(this->GetEntryInfo(std::addressof(entry_info), index));
 
         /* Read the entry to the output buffer. */
-        R_UNLESS(entry_info.size <= out_size, ncm::ResultBufferInsufficient());
+        R_UNLESS(entry_info.size <= static_cast<s64>(out_size), ncm::ResultBufferInsufficient());
         return this->Read(out, out_size, entry_info.offset);
     }
 
@@ -351,7 +351,7 @@ namespace ams::ncm {
         R_TRY(this->GetEntryInfo(std::addressof(entry_info), index));
 
         /* Data size must match existing data size. */
-        R_UNLESS(entry_info.size == data_size, ncm::ResultBufferInsufficient());
+        R_UNLESS(entry_info.size == static_cast<s64>(data_size), ncm::ResultBufferInsufficient());
         return this->Write(data, data_size, entry_info.offset);
     }
 

libraries/libstratosphere/source/ncm/ncm_submission_package_install_task.cpp

@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) 2019-2020 Adubbz, Atmosphère-NX
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#include <stratosphere.hpp>
+#include "ncm_fs_utils.hpp"
+
+namespace ams::ncm {
+
+    class SubmissionPackageInstallTask::Impl {
+        private:
+            fs::FileHandleStorage storage;
+            bool initialized;
+            impl::MountName mount_name;
+        public:
+            Impl(fs::FileHandle handle) : storage(handle), initialized(false) { /* ... */ }
+            ~Impl() {
+                if (this->initialized) {
+                    fs::fsa::Unregister(this->mount_name.str);
+                }
+            }
+
+            Result Initialize() {
+                /* Allocate a partition file system. */
+                auto partition_file_system = std::make_unique<fssystem::PartitionFileSystem>();
+                R_UNLESS(partition_file_system != nullptr, ncm::ResultAllocationFailed());
+
+                /* Create a mount name and register the file system. */
+                auto mount_name = impl::CreateUniqueMountName();
+                R_TRY(fs::fsa::Register(mount_name.str, std::move(partition_file_system)));
+
+                /* Initialize members. */
+                this->mount_name = mount_name;
+                this->initialized = true;
+                return ResultSuccess();
+            }
+
+            const impl::MountName &GetMountName() const {
+                return this->mount_name;
+            }
+    };
+
+    SubmissionPackageInstallTask::~SubmissionPackageInstallTask() {
+        delete impl;
+    }
+
+    Result SubmissionPackageInstallTask::Initialize(fs::FileHandle handle, StorageId storage_id, void *buffer, size_t buffer_size, bool ignore_ticket) {
+        /* Allocate impl. */
+        this->impl = new (std::nothrow) Impl(handle);
+        R_UNLESS(this->impl != nullptr, ncm::ResultAllocationFailed());
+
+        /* Initialize impl. */
+        R_TRY(this->impl->Initialize());
+
+        /* Initialize parent. N doesn't check the result. */
+        PackageInstallTask::Initialize(impl::GetRootDirectoryPath(this->impl->GetMountName()).str, storage_id, buffer, buffer_size, ignore_ticket);
+        return ResultSuccess();
+    }
+
+}