mirrors/Panda3DS
0
0
Fork 0
mirror of https://github.com/wheremyfoodat/Panda3DS.git synced 2025-08-04 23:28:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add proper handling of SetAppCpuTimeLimit with invalid params

Browse source 
Set default time limit to 0
This commit is contained in:
Nomi 2023-12-18 18:41:09 +01:00
commit 99a2e2d7fc
1 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/core/services/apt.cpp
View file

@ -34,8 +34,8 @@ namespace APTCommands {
} }
void APTService::reset() { void APTService::reset() {
// Set the default CPU time limit to 30%. Seems safe, as this is what Metroid 2 uses by default // Set the default CPU time limit to 0%. Appears to be the default value on hardware
cpuTimeLimit = 30; cpuTimeLimit = 0;
// Reset the handles for the various service objects // Reset the handles for the various service objects
lockHandle = std::nullopt; lockHandle = std::nullopt;
@ -311,15 +311,16 @@ void APTService::setApplicationCpuTimeLimit(u32 messagePointer) {
u32 percentage = mem.read32(messagePointer + 8); // CPU time percentage between 5% and 89% u32 percentage = mem.read32(messagePointer + 8); // CPU time percentage between 5% and 89%
log("APT::SetApplicationCpuTimeLimit (percentage = %d%%)\n", percentage); log("APT::SetApplicationCpuTimeLimit (percentage = %d%%)\n", percentage);
mem.write32(messagePointer, IPC::responseHeader(0x4F, 1, 0));
// If called with invalid parameters, the current time limit is left unchanged, and OS::NotImplemented is returned
if (percentage < 5 || percentage > 89 || fixed != 1) { if (percentage < 5 || percentage > 89 || fixed != 1) {
Helpers::warn("Invalid parameter passed to APT::SetApplicationCpuTimeLimit: (percentage, fixed) = (%d, %d)\n", percentage, fixed); Helpers::warn("Invalid parameter passed to APT::SetApplicationCpuTimeLimit: (percentage, fixed) = (%d, %d)\n", percentage, fixed);
// TODO: Does the clamp operation happen? Verify with getApplicationCpuTimeLimit on hardware mem.write32(messagePointer + 4, Result::OS::NotImplemented);
percentage = std::clamp<u32>(percentage, 5, 89); } else {
}
mem.write32(messagePointer, IPC::responseHeader(0x4F, 1, 0));
mem.write32(messagePointer + 4, Result::Success); mem.write32(messagePointer + 4, Result::Success);
cpuTimeLimit = percentage; cpuTimeLimit = percentage;
}
} }
void APTService::getApplicationCpuTimeLimit(u32 messagePointer) { void APTService::getApplicationCpuTimeLimit(u32 messagePointer) {