From b10e69de0e44d89d9e416b834ef1c35ab452862b Mon Sep 17 00:00:00 2001 From: Wunkolo Date: Mon, 17 Jul 2023 09:30:12 -0700 Subject: [PATCH] Add virtual deconstructor override Virtual classes need to override the base-type deconstructor so that they are proper called when referred to by their base-type. --- include/renderer_gl/renderer_gl.hpp | 1 + src/core/renderer_gl/renderer_gl.cpp | 2 ++ 2 files changed, 3 insertions(+) diff --git a/include/renderer_gl/renderer_gl.hpp b/include/renderer_gl/renderer_gl.hpp index 0e7f7bcb..15d12ade 100644 --- a/include/renderer_gl/renderer_gl.hpp +++ b/include/renderer_gl/renderer_gl.hpp @@ -68,6 +68,7 @@ class RendererGL final : public Renderer { public: RendererGL(GPU& gpu, const std::array& internalRegs) : Renderer(gpu, internalRegs) {} + ~RendererGL() override; void reset() override; void display() override; // Display the 3DS screen contents to the window diff --git a/src/core/renderer_gl/renderer_gl.cpp b/src/core/renderer_gl/renderer_gl.cpp index 94639f51..4d948444 100644 --- a/src/core/renderer_gl/renderer_gl.cpp +++ b/src/core/renderer_gl/renderer_gl.cpp @@ -14,6 +14,8 @@ using namespace Floats; using namespace Helpers; using namespace PICA; +RendererGL::~RendererGL() {} + void RendererGL::reset() { depthBufferCache.reset(); colourBufferCache.reset();