mirrors/Ryujinx
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

updates comments

Browse source
This commit is contained in:
Thog 2018-12-04 21:23:33 +01:00
commit 3e6f75772f
No known key found for this signature in database
GPG key ID: 0CD291558FAFDBC6
6 changed files with 7 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Ryujinx.Graphics/Gal/Shader/GlslDecl.cs
View file

@ -239,7 +239,7 @@ namespace Ryujinx.Graphics.Gal.Shader
TextureInstructionSuffix TextureInstructionSuffix; TextureInstructionSuffix TextureInstructionSuffix;
// TODO: non 2d texture type for TEXQ? // TODO: Non 2D texture type for TEXQ?
if (Op.Inst == ShaderIrInst.Texq) if (Op.Inst == ShaderIrInst.Texq)
{ {
TextureType = TextureType.TwoD; TextureType = TextureType.TwoD;

9
Ryujinx.Graphics/Gal/Shader/GlslDecompiler.cs
View file

@ -1236,7 +1236,7 @@ namespace Ryujinx.Graphics.Gal.Shader
private string GetTxlfExpr(ShaderIrOp Op) private string GetTxlfExpr(ShaderIrOp Op)
{ {
// TODO: DC AND MZ // TODO: Support all suffixes
ShaderIrMetaTex Meta = (ShaderIrMetaTex)Op.MetaData; ShaderIrMetaTex Meta = (ShaderIrMetaTex)Op.MetaData;
TextureInstructionSuffix Suffix = Meta.TextureInstructionSuffix; TextureInstructionSuffix Suffix = Meta.TextureInstructionSuffix;
@ -1405,7 +1405,6 @@ namespace Ryujinx.Graphics.Gal.Shader
if (ImageUtils.IsArray(Meta.TextureType)) if (ImageUtils.IsArray(Meta.TextureType))
Coords -= 1; Coords -= 1;
// FIXME: DC not supported
switch (Coords) switch (Coords)
{ {
case 1: case 1:
@ -1436,7 +1435,7 @@ namespace Ryujinx.Graphics.Gal.Shader
Comp = GetOperExpr(Op, Meta.DepthCompare); Comp = GetOperExpr(Op, Meta.DepthCompare);
} }
// TODO // TODO: Support AOFFI
if ((Suffix & TextureInstructionSuffix.AOFFI) != 0) if ((Suffix & TextureInstructionSuffix.AOFFI) != 0)
{ {
throw new NotSupportedException(); throw new NotSupportedException();
@ -1457,7 +1456,7 @@ namespace Ryujinx.Graphics.Gal.Shader
ChString = ""; ChString = "";
} }
// TODO: support LBA and LLA and DC // TODO: Support LBA and LLA
if ((Suffix & TextureInstructionSuffix.LZ) != 0) if ((Suffix & TextureInstructionSuffix.LZ) != 0)
{ {
if ((Suffix & TextureInstructionSuffix.AOFFI) != 0) if ((Suffix & TextureInstructionSuffix.AOFFI) != 0)
@ -1499,8 +1498,6 @@ namespace Ryujinx.Graphics.Gal.Shader
} }
else else
{ {
// FIXME: implement DC
// Load Standard
return "texture(" + Sampler + ", " + Coords + ")" + ChString; return "texture(" + Sampler + ", " + Coords + ")" + ChString;
} }
throw new NotImplementedException($"Texture Suffix {Meta.TextureInstructionSuffix} is not implemented"); throw new NotImplementedException($"Texture Suffix {Meta.TextureInstructionSuffix} is not implemented");

1
Ryujinx.Graphics/Graphics3d/NvGpuEngine2d.cs
View file

@ -38,7 +38,6 @@ namespace Ryujinx.Graphics.Graphics3d
} }
} }
// FIXME: SUPPORT NON 2D
private void TextureCopy(NvGpuVmm Vmm) private void TextureCopy(NvGpuVmm Vmm)
{ {
CopyOperation Operation = (CopyOperation)ReadRegister(NvGpuEngine2dReg.CopyOperation); CopyOperation Operation = (CopyOperation)ReadRegister(NvGpuEngine2dReg.CopyOperation);

2
Ryujinx.Graphics/Graphics3d/NvGpuEngine3d.cs
View file

@ -262,7 +262,7 @@ namespace Ryujinx.Graphics.Graphics3d
GalImageFormat Format = ImageUtils.ConvertZeta((GalZetaFormat)ZetaFormat); GalImageFormat Format = ImageUtils.ConvertZeta((GalZetaFormat)ZetaFormat);
// TODO: all texture types // TODO: Support non 2D?
GalImage Image = new GalImage(Width, Height, 1, 1, GobBlockHeight, Layout, Format, TextureType.TwoD); GalImage Image = new GalImage(Width, Height, 1, 1, GobBlockHeight, Layout, Format, TextureType.TwoD);
Gpu.ResourceManager.SendZetaBuffer(Vmm, Key, Image); Gpu.ResourceManager.SendZetaBuffer(Vmm, Key, Image);

2
Ryujinx.Graphics/Graphics3d/Texture/ASTCDecoder.cs
View file

@ -72,7 +72,7 @@ namespace Ryujinx.Graphics.Texture
if (BlockZ != 1 || Z != 1) if (BlockZ != 1 || Z != 1)
{ {
// TODO: support 3D textures? // TODO: Support 3D textures?
throw new ASTCDecoderException("3D compressed textures unsupported!"); throw new ASTCDecoderException("3D compressed textures unsupported!");
} }

4
Ryujinx.Graphics/Graphics3d/Texture/ImageUtils.cs
View file

@ -96,7 +96,6 @@ namespace Ryujinx.Graphics.Texture
private static readonly Dictionary<GalImageFormat, ImageDescriptor> s_ImageTable = private static readonly Dictionary<GalImageFormat, ImageDescriptor> s_ImageTable =
new Dictionary<GalImageFormat, ImageDescriptor>() new Dictionary<GalImageFormat, ImageDescriptor>()
{ {
// TODO: check if everything is alright here
{ GalImageFormat.RGBA32, new ImageDescriptor(16, 1, 1, 1, TargetBuffer.Color) }, { GalImageFormat.RGBA32, new ImageDescriptor(16, 1, 1, 1, TargetBuffer.Color) },
{ GalImageFormat.RGBA16, new ImageDescriptor(8, 1, 1, 1, TargetBuffer.Color) }, { GalImageFormat.RGBA16, new ImageDescriptor(8, 1, 1, 1, TargetBuffer.Color) },
{ GalImageFormat.RG32, new ImageDescriptor(8, 1, 1, 1, TargetBuffer.Color) }, { GalImageFormat.RG32, new ImageDescriptor(8, 1, 1, 1, TargetBuffer.Color) },
@ -299,7 +298,7 @@ namespace Ryujinx.Graphics.Texture
} }
} }
// TODO: SUPPORT NON 2D // TODO: Support non 2D
public static bool CopyTexture( public static bool CopyTexture(
NvGpuVmm Vmm, NvGpuVmm Vmm,
GalImage SrcImage, GalImage SrcImage,
@ -339,7 +338,6 @@ namespace Ryujinx.Graphics.Texture
return true; return true;
} }
// FIXME: Check if that does the trick
public static int GetSize(GalImage Image) public static int GetSize(GalImage Image)
{ {
ImageDescriptor Desc = GetImageDescriptor(Image.Format); ImageDescriptor Desc = GetImageDescriptor(Image.Format);