mirrors/Ryujinx
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid an unwanted implicit cast of the operator >= to long, continuing to check for negative values. Remove a leftover.

Browse source
This commit is contained in:
LDj3SNuD 2018-10-23 01:22:12 +02:00 • committed by GitHub
commit 40ed925d0d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
ChocolArm64/Instruction/AInstEmitSimdHelper.cs
View file

@ -1274,8 +1274,6 @@ namespace ChocolArm64.Instruction
{ {
ThrowIfInvalid(Index, Size); ThrowIfInvalid(Index, Size);
IAOpCodeSimd Op = (IAOpCodeSimd)Context.CurrOp;
Context.EmitLdvec(Reg); Context.EmitLdvec(Reg);
Context.EmitLdc_I4(Index); Context.EmitLdc_I4(Index);
Context.EmitLdc_I4(Size); Context.EmitLdc_I4(Size);
@ -1470,12 +1468,12 @@ namespace ChocolArm64.Instruction
private static void ThrowIfInvalid(int Index, int Size) private static void ThrowIfInvalid(int Index, int Size)
{ {
if ((uint)Size > 3) if ((uint)Size > 3u)
{ {
throw new ArgumentOutOfRangeException(nameof(Size)); throw new ArgumentOutOfRangeException(nameof(Size));
} }
if ((uint)Index >= 16 >> Size) if ((uint)Index >= 16u >> Size)
{ {
throw new ArgumentOutOfRangeException(nameof(Index)); throw new ArgumentOutOfRangeException(nameof(Index));
} }
@ -1483,12 +1481,12 @@ namespace ChocolArm64.Instruction
private static void ThrowIfInvalidF(int Index, int Size) private static void ThrowIfInvalidF(int Index, int Size)
{ {
if ((uint)Size > 1) if ((uint)Size > 1u)
{ {
throw new ArgumentOutOfRangeException(nameof(Size)); throw new ArgumentOutOfRangeException(nameof(Size));
} }
if ((uint)Index >= 4 >> Size) if ((uint)Index >= 4u >> Size)
{ {
throw new ArgumentOutOfRangeException(nameof(Index)); throw new ArgumentOutOfRangeException(nameof(Index));
} }