Resolved comments from review

This commit is contained in:
Andy Adshead 2019-04-15 21:38:19 +01:00
parent bd66549563
commit 4734b6cf18
4 changed files with 4 additions and 4 deletions

View file

@ -108,7 +108,7 @@ namespace Ryujinx.HLE.HOS.Services
string serviceName;
DummyService dummyService = service as DummyService;
serviceName = (dummyService == null) ? serviceName = service.GetType().FullName : dummyService.ServiceName;
serviceName = (dummyService == null) ? service.GetType().FullName : dummyService.ServiceName;
Logger.PrintWarning(LogClass.KernelIpc, $"Missing service {serviceName}: {commandId} ignored");
}

View file

@ -44,7 +44,7 @@
// Enable or disable aggressive CPU optimizations
"enable_aggressive_cpu_opts": true,
// Enable or disable ignoring missing services, this may cause instability however lets some games progress further
// Enable or disable ignoring missing services, this may cause instability
"ignore_missing_services": false,
// The primary controller's type

View file

@ -4,6 +4,7 @@ using Ryujinx.Common;
using Ryujinx.Common.Logging;
using Ryujinx.HLE;
using Ryujinx.HLE.HOS.SystemState;
using Ryujinx.HLE.HOS.Services;
using Ryujinx.HLE.Input;
using Ryujinx.UI.Input;
using System;
@ -11,7 +12,6 @@ using System.IO;
using System.Threading.Tasks;
using Utf8Json;
using Utf8Json.Resolvers;
using Ryujinx.HLE.HOS.Services;
namespace Ryujinx
{

View file

@ -415,7 +415,7 @@
"$id": "#/properties/ignore_missing_services",
"type": "boolean",
"title": "Ignore Missing Services",
"description": "Enable or disable ignoring missing services, this may cause instability however lets some games progress further",
"description": "Enable or disable ignoring missing services, this may cause instability",
"default": false,
"examples": [
true,