From 48b352ea1a0d92273741adb661ea08ab5fbcc801 Mon Sep 17 00:00:00 2001
From: Furoryan <florian.leman@gmail.com>
Date: Wed, 31 Jul 2024 08:50:54 +0200
Subject: [PATCH] Fix Aes shift rows and inv shift rows Soft Fallback

srPerm and _isrPerm were inverted.

Definition in reference manual :
 bits(128) AESShiftRows(bits(128) op)
     return (
         op< 95: 88> : op< 55: 48> : op< 15:  8> : op<103: 96> :
         op< 63: 56> : op< 23: 16> : op<111:104> : op< 71: 64> :
         op< 31: 24> : op<119:112> : op< 79: 72> : op< 39: 32> :
         op<127:120> : op< 87: 80> : op< 47: 40> : op<  7:  0>
     );

 bits(128) AESInvShiftRows(bits(128) op)
     return (
         op< 31: 24> : op< 55: 48> : op< 79: 72> : op<103: 96> :
         op<127:120> : op< 23: 16> : op< 47: 40> : op< 71: 64> :
         op< 95: 88> : op<119:112> : op< 15:  8> : op< 39: 32> :          op< 63: 56> : op< 87: 80> : op<111:104> : op<  7:  0>
     );
---
 src/ARMeilleure/Instructions/CryptoHelper.cs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ARMeilleure/Instructions/CryptoHelper.cs b/src/ARMeilleure/Instructions/CryptoHelper.cs
index ba68cebb37..26e70b23fe 100644
--- a/src/ARMeilleure/Instructions/CryptoHelper.cs
+++ b/src/ARMeilleure/Instructions/CryptoHelper.cs
@@ -171,12 +171,12 @@ namespace ARMeilleure.Instructions
 
         private static ReadOnlySpan<byte> _srPerm => new byte[]
         {
-            0, 13, 10, 7, 4, 1, 14, 11, 8, 5, 2, 15, 12, 9, 6, 3,
+            0, 5, 10, 15, 4, 9, 14, 3, 8, 13, 2, 7, 12, 1, 6, 11
         };
 
         private static ReadOnlySpan<byte> _isrPerm => new byte[]
         {
-            0, 5, 10, 15, 4, 9, 14, 3, 8, 13, 2, 7, 12, 1, 6, 11,
+            0, 13, 10, 7, 4, 1, 14, 11, 8, 5, 2, 15, 12, 9, 6, 3
         };
 #pragma warning restore IDE1006
         #endregion