mirrors/Ryujinx
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use dynamic state properly, cleanup.

Browse source
This commit is contained in:
riperiperi 2024-08-30 20:14:23 +01:00
commit bd0737ba51
4 changed files with 4 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/Ryujinx.Graphics.Vulkan/BarrierBatch.cs
View file

@ -55,20 +55,6 @@ namespace Ryujinx.Graphics.Vulkan
stages |= PipelineStageFlags.TransformFeedbackBitExt; stages |= PipelineStageFlags.TransformFeedbackBitExt;
} }
if (!gd.IsTBDR)
{
// Desktop GPUs can transform image barriers into memory barriers.
// ...but these cause VUID-VkSubpassDependency-srcSubpass-06809
/*
access |= AccessFlags.DepthStencilAttachmentWriteBit | AccessFlags.ColorAttachmentWriteBit;
access |= AccessFlags.DepthStencilAttachmentReadBit | AccessFlags.ColorAttachmentReadBit;
stages |= PipelineStageFlags.EarlyFragmentTestsBit | PipelineStageFlags.LateFragmentTestsBit;
stages |= PipelineStageFlags.ColorAttachmentOutputBit;
*/
}
return (access, stages); return (access, stages);
} }

1
src/Ryujinx.Graphics.Vulkan/HardwareCapabilities.cs
View file

@ -126,6 +126,7 @@ namespace Ryujinx.Graphics.Vulkan
SupportsHostImportedMemory = supportsHostImportedMemory; SupportsHostImportedMemory = supportsHostImportedMemory;
SupportsDepthClipControl = supportsDepthClipControl; SupportsDepthClipControl = supportsDepthClipControl;
SupportsAttachmentFeedbackLoop = supportsAttachmentFeedbackLoop; SupportsAttachmentFeedbackLoop = supportsAttachmentFeedbackLoop;
SupportsDynamicAttachmentFeedbackLoop = supportsDynamicAttachmentFeedbackLoop;
SubgroupSize = subgroupSize; SubgroupSize = subgroupSize;
SupportedSampleCounts = supportedSampleCounts; SupportedSampleCounts = supportedSampleCounts;
PortabilitySubset = portabilitySubset; PortabilitySubset = portabilitySubset;

3
src/Ryujinx.Graphics.Vulkan/PipelineBase.cs
View file

@ -1566,7 +1566,8 @@ namespace Ryujinx.Graphics.Vulkan
foreach (TextureView view in hazards) foreach (TextureView view in hazards)
{ {
// TODO: enforce layout // May need to enforce feedback loop layout here in the future.
// Though technically, it should always work with the general layout.
if (view.Info.Format.IsDepthOrStencil()) if (view.Info.Format.IsDepthOrStencil())
{ {

1
src/Ryujinx.Graphics.Vulkan/VulkanInitialization.cs
View file

@ -45,6 +45,7 @@ namespace Ryujinx.Graphics.Vulkan
"VK_KHR_8bit_storage", "VK_KHR_8bit_storage",
"VK_KHR_maintenance2", "VK_KHR_maintenance2",
"VK_EXT_attachment_feedback_loop_layout", "VK_EXT_attachment_feedback_loop_layout",
"VK_EXT_attachment_feedback_loop_dynamic_state",
}; };
private static readonly string[] _requiredExtensions = { private static readonly string[] _requiredExtensions = {