mirrors/Ryujinx
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Throw an exception instead of returning null for SwitchPathToSystemPath and GetFullPath

Browse source
This commit is contained in:
TSR Berry 2024-07-11 00:43:27 +02:00
commit d3d08ae136
No known key found for this signature in database
GPG key ID: 52353C0A4CCA15E2
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/Ryujinx.HLE/FileSystem/VirtualFileSystem.cs
View file

@ -98,14 +98,14 @@ namespace Ryujinx.HLE.FileSystem
} }
else else
{ {
return null; throw new ArgumentException($"The filename does not start with '/': {fileName}", nameof(fileName));
} }
string fullPath = Path.GetFullPath(Path.Combine(basePath, fileName)); string fullPath = Path.GetFullPath(Path.Combine(basePath, fileName));
if (!fullPath.StartsWith(AppDataManager.BaseDirPath)) if (!fullPath.StartsWith(AppDataManager.BaseDirPath))
{ {
return null; throw new ArgumentException($"The path is not located inside the Ryujinx directory: {fullPath}", nameof(basePath));
} }
return fullPath; return fullPath;
@ -120,7 +120,7 @@ namespace Ryujinx.HLE.FileSystem
if (parts.Length != 2) if (parts.Length != 2)
{ {
return null; throw new ArgumentException($"Invalid switch fs path provided: {switchPath}", nameof(switchPath));
} }
return GetFullPath(MakeFullPath(parts[0]), parts[1]); return GetFullPath(MakeFullPath(parts[0]), parts[1]);