Fix review

This commit is contained in:
Ac_K 2019-11-21 02:03:05 +01:00
parent 4afab91e9b
commit da9978f98a
2 changed files with 5 additions and 8 deletions

View file

@ -21,7 +21,7 @@ namespace Ryujinx.HLE.HOS.Services.Ldn
_state = NetworkState.None;
}
public ResultCode Initialize(int unknown, int version = 0, IPAddress ipv4Address = null, IPAddress subnetMaskAddress = null)
public ResultCode Initialize(int unknown, int version, IPAddress ipv4Address, IPAddress subnetMaskAddress)
{
// TODO(Ac_K): Call nn::nifm::InitializeSystem().
// If the call failed, it returns the result code.

View file

@ -55,7 +55,7 @@ namespace Ryujinx.HLE.HOS.Services.Ldn.UserServiceCreator
context.Response.HandleDesc = IpcHandleDesc.MakeCopy(_stateChangeEventHandle);
// Return ResultCode.InvalidArgument if handle is null, doesn't occur in our case.
// Return ResultCode.InvalidArgument if handle is null, doesn't occur in our case since we already throw an Exception.
return ResultCode.Success;
}
@ -64,7 +64,7 @@ namespace Ryujinx.HLE.HOS.Services.Ldn.UserServiceCreator
// InitializeOld(u64, pid)
public ResultCode InitializeOld(ServiceCtx context)
{
return _networkInterface.Initialize(UnknownValue);
return _networkInterface.Initialize(UnknownValue, 0, null, null);
}
[Command(401)]
@ -79,11 +79,8 @@ namespace Ryujinx.HLE.HOS.Services.Ldn.UserServiceCreator
public ResultCode Initialize(ServiceCtx context)
{
// TODO(Ac_K): Determine what addresses are.
ulong ipAddresses = context.RequestData.ReadUInt64();
IPAddress unknownAddress1 = new IPAddress((uint)(ipAddresses & uint.MaxValue));
IPAddress unknownAddress2 = new IPAddress((uint)(ipAddresses >> 32));
IPAddress unknownAddress1 = new IPAddress(context.RequestData.ReadUInt32());
IPAddress unknownAddress2 = new IPAddress(context.RequestData.ReadUInt32());
return _networkInterface.Initialize(UnknownValue, version: 1, unknownAddress1, unknownAddress2);
}