Implement or

This commit is contained in:
Andrzej Janik 2020-10-01 20:28:57 +02:00
parent 96a342e33f
commit bd3d440dba
4 changed files with 41 additions and 1 deletions

View file

@ -345,6 +345,7 @@ pub enum Instruction<P: ArgParams> {
Call(CallInst<P>),
Abs(AbsDetails, Arg2<P>),
Mad(MulDetails, Arg4<P>),
Or(OrType, Arg3<P>),
}
#[derive(Copy, Clone)]
@ -802,3 +803,10 @@ pub enum StCacheOperator {
pub struct RetData {
pub uniform: bool,
}
sub_scalar_type!(OrType {
Pred,
B16,
B32,
B64,
});

View file

@ -127,6 +127,7 @@ match {
"mov",
"mul",
"not",
"or",
"ret",
"setp",
"shl",
@ -155,6 +156,7 @@ ExtendedID : &'input str = {
"mov",
"mul",
"not",
"or",
"ret",
"setp",
"shl",
@ -445,7 +447,8 @@ Instruction: ast::Instruction<ast::ParsedArgParams<'input>> = {
InstCvta,
InstCall,
InstAbs,
InstMad
InstMad,
InstOr
};
// https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#data-movement-and-conversion-instructions-ld
@ -1048,6 +1051,18 @@ SignedIntType: ast::ScalarType = {
".s64" => ast::ScalarType::S64,
};
// https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#logic-and-shift-instructions-or
InstOr: ast::Instruction<ast::ParsedArgParams<'input>> = {
"or" <d:OrType> <a:Arg3> => ast::Instruction::Or(d, a),
};
OrType: ast::OrType = {
".pred" => ast::OrType::Pred,
".b16" => ast::OrType::B16,
".b32" => ast::OrType::B32,
".b64" => ast::OrType::B64,
}
Operand: ast::Operand<&'input str> = {
<r:ExtendedID> => ast::Operand::Reg(r),
<r:ExtendedID> "+" <o:Num> => {

View file

@ -69,6 +69,7 @@ test_ptx!(mad_s32, [2i32, 3i32, 4i32], [10i32, 10i32, 10i32]);
test_ptx!(mul_wide, [0x01_00_00_00__01_00_00_00i64], [0x1_00_00_00_00_00_00i64]);
test_ptx!(vector_extract, [1u8, 2u8, 3u8, 4u8], [3u8, 4u8, 1u8, 2u8]);
test_ptx!(shr, [-2i32], [-1i32]);
test_ptx!(or, [1u64, 2u64], [3u64]);
struct DisplayError<T: Debug> {

View file

@ -592,6 +592,9 @@ fn convert_to_typed_statements(
ast::Instruction::Shr(d, a) => {
result.push(Statement::Instruction(ast::Instruction::Shr(d, a.cast())))
}
ast::Instruction::Or(d, a) => {
result.push(Statement::Instruction(ast::Instruction::Or(d, a.cast())))
}
},
Statement::Label(i) => result.push(Statement::Label(i)),
Statement::Variable(v) => result.push(Statement::Variable(v)),
@ -1583,6 +1586,14 @@ fn emit_function_body_ops(
}
ast::MulDetails::Float(desc) => emit_mad_float(builder, map, desc, arg)?,
},
ast::Instruction::Or(t, a) => {
let result_type = map.get_or_add_scalar(builder, ast::ScalarType::from(*t));
if *t == ast::OrType::Pred {
builder.logical_or(result_type, Some(a.dst), a.src1, a.src2)?;
} else {
builder.bitwise_or(result_type, Some(a.dst), a.src1, a.src2)?;
}
}
},
Statement::LoadVar(arg, typ) => {
let type_id = map.get_or_add(builder, SpirvType::from(*typ));
@ -2905,6 +2916,10 @@ impl<T: ArgParamsEx> ast::Instruction<T> {
let is_wide = d.is_wide();
ast::Instruction::Mad(d, a.map(visitor, inst_type, is_wide)?)
}
ast::Instruction::Or(t, a) => ast::Instruction::Or(
t,
a.map_non_shift(visitor, ast::Type::Scalar(t.into()), false)?,
),
})
}
}
@ -3113,6 +3128,7 @@ impl ast::Instruction<ExpandedArgParams> {
| ast::Instruction::Ret(_)
| ast::Instruction::Abs(_, _)
| ast::Instruction::Call(_)
| ast::Instruction::Or(_, _)
| ast::Instruction::Mad(_, _) => None,
}
}