From 71f411e458f11067c12cd17016055c37c5e3c25e Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 19 May 2011 00:29:30 +0100 Subject: [PATCH] Some comment explanation. --- deluge/ui/client.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/deluge/ui/client.py b/deluge/ui/client.py index d356b228b..b2de0b138 100644 --- a/deluge/ui/client.py +++ b/deluge/ui/client.py @@ -182,6 +182,13 @@ class DelugeRPCProtocol(Protocol): exception_cls = getattr(error, request[2]) exception = exception_cls(*request[3], **request[4]) + # Ideally we would chain the deferreds instead of instance + # checking just to log them. But, that would mean that any + # errback on the fist deferred should returns it's failure + # so it could pass back to the 2nd deferred on the chain. But, + # that does not always happen. + # So, just do some instance checking and just log rpc error at + # diferent levels. r = self.__rpc_requests[request_id] msg = "RPCError Message Received!" msg += "\n" + "-" * 80