mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-03 08:52:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ControllerInterface/Device: Use std::string_view where applicable

Browse source 
In these cases, the given string is only ever compared against other
string, so std::string can be turned into a std::string_view to allow
non-allocating inputs.
This commit is contained in:
Lioncash 2019-05-29 18:42:22 -04:00
parent 80d8173d29
commit 1355b43fd2
2 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Source/Core/InputCommon/ControllerInterface/Device.cpp
View file

@ -52,7 +52,7 @@ std::string Device::GetQualifiedName() const
return StringFromFormat("%s/%i/%s", this->GetSource().c_str(), GetId(), this->GetName().c_str());
}
Device::Input* Device::FindInput(const std::string& name) const
Device::Input* Device::FindInput(std::string_view name) const
{
for (Input* input : m_inputs)
{
@ -63,7 +63,7 @@ Device::Input* Device::FindInput(const std::string& name) const
return nullptr;
}
Device::Output* Device::FindOutput(const std::string& name) const
Device::Output* Device::FindOutput(std::string_view name) const
{
for (Output* output : m_outputs)
{
@ -74,7 +74,7 @@ Device::Output* Device::FindOutput(const std::string& name) const
return nullptr;
}
bool Device::Control::IsMatchingName(const std::string& name) const
bool Device::Control::IsMatchingName(std::string_view name) const
{
return GetName() == name;
}
@ -90,7 +90,7 @@ std::string Device::FullAnalogSurface::GetName() const
return "Full " + m_high.GetName();
}
bool Device::FullAnalogSurface::IsMatchingName(const std::string& name) const
bool Device::FullAnalogSurface::IsMatchingName(std::string_view name) const
{
if (Control::IsMatchingName(name))
return true;
@ -218,7 +218,7 @@ std::string DeviceContainer::GetDefaultDeviceString() const
return device_qualifier.ToString();
}
Device::Input* DeviceContainer::FindInput(const std::string& name, const Device* def_dev) const
Device::Input* DeviceContainer::FindInput(std::string_view name, const Device* def_dev) const
{
if (def_dev)
{
@ -239,7 +239,7 @@ Device::Input* DeviceContainer::FindInput(const std::string& name, const Device*
return nullptr;
}
Device::Output* DeviceContainer::FindOutput(const std::string& name, const Device* def_dev) const
Device::Output* DeviceContainer::FindOutput(std::string_view name, const Device* def_dev) const
{
return def_dev->FindOutput(name);
}