mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-08-24 19:27:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

VertexManagerBase: Make CreateNativeVertexFormat return a unique_ptr

Browse source 
Much safer as opposed to just returning raw allocated memory.
This commit is contained in:
Lioncash 2017-02-18 03:14:30 -05:00
commit 1fa81f24d3
15 changed files with 36 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Source/Core/VideoBackends/D3D/NativeVertexFormat.cpp
View file

@ -27,10 +27,10 @@ private:
ID3D11InputLayout* m_layout = nullptr;
};
NativeVertexFormat*
std::unique_ptr<NativeVertexFormat>
VertexManager::CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl)
{
return new D3DVertexFormat(vtx_decl);
return std::make_unique<D3DVertexFormat>(vtx_decl);
}
static const DXGI_FORMAT d3d_format_lookup[5 * 4 * 2] = {

5
Source/Core/VideoBackends/D3D/VertexManager.h
View file

@ -4,6 +4,7 @@
#pragma once
#include <memory>
#include "VideoCommon/VertexManagerBase.h"
struct ID3D11Buffer;
@ -16,7 +17,9 @@ public:
VertexManager();
~VertexManager();
NativeVertexFormat* CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl) override;
std::unique_ptr<NativeVertexFormat>
CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl) override;
void CreateDeviceObjects() override;
void DestroyDeviceObjects() override;