mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-08-26 20:25:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

VertexManagerBase: Make CreateNativeVertexFormat return a unique_ptr

Browse source 
Much safer as opposed to just returning raw allocated memory.
This commit is contained in:
Lioncash 2017-02-18 03:14:30 -05:00
commit 1fa81f24d3
15 changed files with 36 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Source/Core/VideoBackends/D3D12/D3DState.cpp
View file

@ -81,7 +81,7 @@ public:
if (!native)
{
native.reset(g_vertex_manager->CreateNativeVertexFormat(native_vtx_decl));
native = g_vertex_manager->CreateNativeVertexFormat(native_vtx_decl);
}
desc.InputLayout = reinterpret_cast<D3DVertexFormat*>(native.get())->GetActiveInputLayout12();

4
Source/Core/VideoBackends/D3D12/NativeVertexFormat.cpp
View file

@ -13,10 +13,10 @@
namespace DX12
{
NativeVertexFormat*
std::unique_ptr<NativeVertexFormat>
VertexManager::CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl)
{
return new D3DVertexFormat(vtx_decl);
return std::make_unique<D3DVertexFormat>(vtx_decl);
}
static const constexpr DXGI_FORMAT d3d_format_lookup[5 * 4 * 2] = {

4
Source/Core/VideoBackends/D3D12/VertexManager.h
View file

@ -17,7 +17,9 @@ public:
VertexManager();
~VertexManager();
NativeVertexFormat* CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl) override;
std::unique_ptr<NativeVertexFormat>
CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl) override;
void CreateDeviceObjects() override;
void DestroyDeviceObjects() override;