mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-08-05 15:48:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing lint and reported CI errors

Browse source
This commit is contained in:
Nitch2024 2025-03-26 13:22:39 -07:00
commit 267e6608d3
2 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
View file

@ -1060,10 +1060,7 @@ void CodeViewWidget::DoPatchInstruction(bool assemble)
if (assemble) if (assemble)
{ {
std::string code_line = [this, addr] { std::string code_line = m_system.GetPowerPC().GetDebugInterface().Disassemble(&guard, addr);
Core::CPUThreadGuard guard(m_system);
return m_system.GetPowerPC().GetDebugInterface().Disassemble(&guard, addr);
}();
std::ranges::replace(code_line, '\t', ' ' ); std::ranges::replace(code_line, '\t', ' ' );

9
Source/Core/DolphinQt/Debugger/MemoryWidget.cpp
View file

@ -168,7 +168,7 @@ void MemoryWidget::CreateWidgets()
m_result_label = new QLabel; m_result_label = new QLabel;
auto* search_bp_group = new QHBoxLayout; auto* search_bp_group = new QHBoxLayout;
auto *auto_bp_label = new QLabel(tr("Auto BP")); auto* auto_bp_label = new QLabel(tr("Auto BP"));
m_find_auto_mem_bp = new QCheckBox(tr("Mem")); m_find_auto_mem_bp = new QCheckBox(tr("Mem"));
m_find_auto_code_bp = new QCheckBox(tr("Code")); m_find_auto_code_bp = new QCheckBox(tr("Code"));
search_bp_group->addWidget(auto_bp_label); search_bp_group->addWidget(auto_bp_label);
@ -366,7 +366,7 @@ void MemoryWidget::ConnectWidgets()
{ {
connect(radio, &QRadioButton::toggled, this, &MemoryWidget::OnAddressSpaceChanged); connect(radio, &QRadioButton::toggled, this, &MemoryWidget::OnAddressSpaceChanged);
} }
for (auto* combo : {m_display_combo, m_align_combo, m_row_length_combo, m_find_align }) for (auto* combo : {m_display_combo, m_align_combo, m_row_length_combo, m_find_align})
{ {
connect(combo, &QComboBox::currentIndexChanged, this, &MemoryWidget::OnDisplayChanged); connect(combo, &QComboBox::currentIndexChanged, this, &MemoryWidget::OnDisplayChanged);
} }
@ -383,7 +383,8 @@ void MemoryWidget::ConnectWidgets()
connect(m_memory_view, &MemoryViewWidget::ShowCode, this, &MemoryWidget::ShowCode); connect(m_memory_view, &MemoryViewWidget::ShowCode, this, &MemoryWidget::ShowCode);
connect(m_memory_view, &MemoryViewWidget::RequestWatch, this, &MemoryWidget::RequestWatch); connect(m_memory_view, &MemoryViewWidget::RequestWatch, this, &MemoryWidget::RequestWatch);
connect(m_memory_view, &MemoryViewWidget::ActivateSearch, this, &MemoryWidget::ActivateSearchAddress); connect(m_memory_view, &MemoryViewWidget::ActivateSearch, this,
&MemoryWidget::ActivateSearchAddress);
} }
void MemoryWidget::closeEvent(QCloseEvent*) void MemoryWidget::closeEvent(QCloseEvent*)
@ -949,7 +950,7 @@ void MemoryWidget::OnFindNextValue()
{ {
m_memory_view->ToggleBreakpoint(m_memory_view->GetAddress(), false); m_memory_view->ToggleBreakpoint(m_memory_view->GetAddress(), false);
} }
if (set_code_bp && ( 4 <= alignment ) ) if (set_code_bp && (4 <= alignment))
{ {
m_system.GetPowerPC().GetBreakPoints().ToggleBreakPoint(m_memory_view->GetAddress()); m_system.GetPowerPC().GetBreakPoints().ToggleBreakPoint(m_memory_view->GetAddress());
emit Host::GetInstance()->PPCBreakpointsChanged(); emit Host::GetInstance()->PPCBreakpointsChanged();