Fix some cases of variables being used uninitialized. Also some unused

variables, writeable strings and dangerously shadowed variables.

index(), gamma(), exp() and y0() are POSIX functions and using those
names can cause namespace confusion.

A number of C files were missing the final newline required by ANSI C
and some versions of GCC are pedantic enough to complain about this.

These changes simply the scons build, allowing us to get rid of
filterWarnings which is simply more trouble than it's worth.


git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@5574 8ced0084-cf51-0410-be5f-012b33b47a6e

SconsTests/utils.py

@@ -1,14 +1,6 @@
 import os
 import platform
 
-# methods that should be added to env
-def filterWarnings(self, flags):
-    return ' '.join(
-        flag
-        for flag in flags
-        if not flag.startswith('-W')
-        )
-
 # taken from scons wiki
 def CheckPKGConfig(context, version):
     context.Message( 'Checking for pkg-config version > %s... ' % version)
@@ -28,8 +20,7 @@ def CheckFramework(context, name):
               }
               """, '.c')
         if not ret:
-            context.env.Replace(FRAMEWORKS = lastFRAMEWORKS
-)
+            context.env.Replace(FRAMEWORKS = lastFRAMEWORKS)
 
     return ret