VideoCommon: don't do pointer copies during graphics mod callback iteration

This commit is contained in:
iwubcode 2023-07-02 13:58:07 -05:00 committed by Nayla Hanegan
parent f63e4aef0e
commit 431adad91a
No known key found for this signature in database
GPG key ID: 3075216CED0DB01D
3 changed files with 7 additions and 7 deletions

View file

@ -406,14 +406,14 @@ void VertexShaderManager::SetConstants(const std::vector<std::string>& textures)
std::vector<GraphicsModAction*> projection_actions;
if (g_ActiveConfig.bGraphicMods)
{
for (const auto action : g_graphics_mod_manager->GetProjectionActions(xfmem.projection.type))
for (const auto& action : g_graphics_mod_manager->GetProjectionActions(xfmem.projection.type))
{
projection_actions.push_back(action);
}
for (const auto& texture : textures)
{
for (const auto action :
for (const auto& action :
g_graphics_mod_manager->GetProjectionTextureActions(xfmem.projection.type, texture))
{
projection_actions.push_back(action);
@ -430,7 +430,7 @@ void VertexShaderManager::SetConstants(const std::vector<std::string>& textures)
auto corrected_matrix = LoadProjectionMatrix();
GraphicsModActionData::Projection projection{&corrected_matrix};
for (auto action : projection_actions)
for (const auto& action : projection_actions)
{
action->OnProjection(&projection);
}