mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-09-13 04:52:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #12389 from lioncash/cheeve

Browse source 
AchievementManager: Make GetInstance() and GetLock() return a reference
This commit is contained in:
Admiral H. Curtiss 2023-12-11 23:37:29 +01:00 • committed by GitHub
commit 54301d709a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
22 changed files with 87 additions and 117 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Source/Core/VideoCommon/OnScreenUI.cpp
View file

@ -330,10 +330,9 @@ void OnScreenUI::DrawDebugText()
#ifdef USE_RETRO_ACHIEVEMENTS
void OnScreenUI::DrawChallenges()
{
std::lock_guard lg{*AchievementManager::GetInstance()->GetLock()};
const AchievementManager::NamedIconMap& challenge_icons =
AchievementManager::GetInstance()->GetChallengeIcons();
if (challenge_icons.size() == 0)
std::lock_guard lg{AchievementManager::GetInstance().GetLock()};
const auto& challenge_icons = AchievementManager::GetInstance().GetChallengeIcons();
if (challenge_icons.empty())
return;
const std::string window_name = "Challenges";