Fix multiple minor warnings

- ExpressionParser.cpp: `-Wmissing-declarations`
- AchievementManager.cpp: `-Wsign-compare`
- SI.cpp: `-Warray-bounds=`
- NetPlayClient.cpp: `-Wdangling-reference`
This commit is contained in:
Joshua Vandaële 2025-02-21 01:06:32 +01:00
parent af064c57de
commit 5b4d4ca5eb
No known key found for this signature in database
GPG key ID: 5E8F4E7EDBD390EA
4 changed files with 11 additions and 7 deletions

View file

@ -26,12 +26,12 @@ using namespace ciface::Core;
class ControlExpression;
// Check if operator is usable with assignment, e.g. += -= *=
bool IsCompoundAssignmentUsableBinaryOperator(TokenType type)
static bool IsCompoundAssignmentUsableBinaryOperator(TokenType type)
{
return type >= TOK_COMPOUND_ASSIGN_OPS_BEGIN && type < TOK_COMPOUND_ASSIGN_OPS_END;
}
TokenType GetBinaryOperatorTokenTypeFromChar(char c)
static TokenType GetBinaryOperatorTokenTypeFromChar(char c)
{
switch (c)
{
@ -744,7 +744,7 @@ ParseResult ParseResult::MakeErrorResult(Token token, std::string description)
return result;
}
bool IsInertToken(const Token& tok)
static bool IsInertToken(const Token& tok)
{
return tok.type == TOK_COMMENT || tok.type == TOK_WHITESPACE;
}