mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-08-02 22:29:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #12950 from AdmiralCurtiss/achievement-fix-badge-network-error

Browse source 
AchievementManager: Fix incorrect check on network request return value in FetchBadge()
This commit is contained in:
Tilka 2024-07-23 20:16:54 +01:00 • committed by GitHub
commit 5f4f974b48
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Source/Core/Core/AchievementManager.cpp
View file

@ -1175,7 +1175,7 @@ void AchievementManager::FetchBadge(AchievementManager::Badge* badge, u32 badge_
} }
auto http_response = http_request.Get(api_request.url, USER_AGENT_HEADER, auto http_response = http_request.Get(api_request.url, USER_AGENT_HEADER,
Common::HttpRequest::AllowedReturnCodes::All); Common::HttpRequest::AllowedReturnCodes::All);
if (http_response.has_value() && http_response->size() <= 0) if (!http_response.has_value() || http_response->empty())
{ {
WARN_LOG_FMT(ACHIEVEMENTS, WARN_LOG_FMT(ACHIEVEMENTS,
"RetroAchievements connection failed on image request.\n URL: {}", "RetroAchievements connection failed on image request.\n URL: {}",