mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-30 22:21:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

DolphinQt/Config/GeckoCodeWidget: Make exec() outcomes explicit

Browse source 
Makes it a little more explicit which dialog outcomes we're expecting.
While we're at it, we can invert them into guard clauses to unindent
code a little bit.
This commit is contained in:
Lioncash 2019-07-31 09:16:01 -04:00
parent 255d2ff2d2
commit 6002529ece
1 changed files with 9 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp
View file

@ -185,34 +185,30 @@ void GeckoCodeWidget::AddCode()
CheatCodeEditor ed(this); CheatCodeEditor ed(this);
ed.SetGeckoCode(&code); ed.SetGeckoCode(&code);
if (ed.exec() == QDialog::Rejected)
return;
if (ed.exec())
{
m_gecko_codes.push_back(std::move(code)); m_gecko_codes.push_back(std::move(code));
SaveCodes(); SaveCodes();
UpdateList(); UpdateList();
} }
}
void GeckoCodeWidget::EditCode() void GeckoCodeWidget::EditCode()
{ {
const auto* item = m_code_list->currentItem(); const auto* item = m_code_list->currentItem();
if (item == nullptr) if (item == nullptr)
return; return;
const int index = item->data(Qt::UserRole).toInt(); const int index = item->data(Qt::UserRole).toInt();
CheatCodeEditor ed(this); CheatCodeEditor ed(this);
ed.SetGeckoCode(&m_gecko_codes[index]); ed.SetGeckoCode(&m_gecko_codes[index]);
if (ed.exec() == QDialog::Rejected)
return;
if (ed.exec())
{
SaveCodes(); SaveCodes();
UpdateList(); UpdateList();
} }
}
void GeckoCodeWidget::RemoveCode() void GeckoCodeWidget::RemoveCode()
{ {