mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-28 19:58:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Hide non-channel WADs

Browse source 
These cannot be booted, so it is bad UX to show them in the UI as if
they were regular titles, and yet have different behaviour for them.

And technically, there is no reason to allow them to be used to boot
in the first place.

Another reason they should not be shown is that Dolphin fails
spectacularly with WADs that have a valid boot content index, but are
not PPC titles (e.g. IOS WADs). The only reliable way to avoid this
is to check for the title type and only show channels, just like
the Wii System Menu.
This commit is contained in:
Léo Lam 2017-05-14 00:00:01 +02:00
commit 6916a3d85b
5 changed files with 28 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Source/Core/Core/ConfigManager.cpp
View file

@ -992,13 +992,10 @@ bool SConfig::AutoSetup(EBootBS2 _BootBS2)
DiscIO::CNANDContentManager::Access().GetNANDLoader(m_strFilename);
const IOS::ES::TMDReader& tmd = content_loader.GetTMD();
if (content_loader.GetContentByIndex(tmd.GetBootIndex()) == nullptr)
if (!IOS::ES::IsChannel(tmd.GetTitleId()))
{
// WAD is valid yet cannot be booted. Install instead.
u64 installed = DiscIO::CNANDContentManager::Access().Install_WiiWAD(m_strFilename);
if (installed)
SuccessAlertT("The WAD has been installed successfully");
return false; // do not boot
PanicAlertT("This WAD is not bootable.");
return false;
}
SetRegion(tmd.GetRegion(), &set_region_dir);