mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-08-29 13:45:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup SlippiPane member vars

Browse source
This commit is contained in:
Edgar Handal 2020-07-07 00:01:35 -05:00 • committed by R2DLiu
commit 79e64c5381
2 changed files with 19 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

38
Source/Core/DolphinQt/Settings/SlippiPane.cpp
View file

@ -43,22 +43,22 @@ void SlippiPane::CreateLayout()
replay_settings->setLayout(replay_settings_layout); replay_settings->setLayout(replay_settings_layout);
layout->addWidget(replay_settings); layout->addWidget(replay_settings);
m_enable_replay_save_checkbox = new QCheckBox(tr("Save Slippi Replays")); auto* enable_replay_save_checkbox = new QCheckBox(tr("Save Slippi Replays"));
m_enable_replay_save_checkbox->setToolTip( enable_replay_save_checkbox->setToolTip(
tr("Enable this to make Slippi automatically save .slp recordings of your games.")); tr("Enable this to make Slippi automatically save .slp recordings of your games."));
replay_settings_layout->addWidget(m_enable_replay_save_checkbox); replay_settings_layout->addWidget(enable_replay_save_checkbox);
m_enable_replay_save_checkbox->setChecked(SConfig::GetInstance().m_slippiSaveReplays); enable_replay_save_checkbox->setChecked(SConfig::GetInstance().m_slippiSaveReplays);
connect(m_enable_replay_save_checkbox, &QCheckBox::toggled, this, connect(enable_replay_save_checkbox, &QCheckBox::toggled, this,
[](bool checked) { SConfig::GetInstance().m_slippiSaveReplays = checked; }); [](bool checked) { SConfig::GetInstance().m_slippiSaveReplays = checked; });
m_enable_monthly_replay_folders_checkbox = auto* enable_monthly_replay_folders_checkbox =
new QCheckBox(tr("Save Replays to Monthly Subfolders")); new QCheckBox(tr("Save Replays to Monthly Subfolders"));
m_enable_monthly_replay_folders_checkbox->setToolTip( enable_monthly_replay_folders_checkbox->setToolTip(
tr("Enable this to save your replays into subfolders by month (YYYY-MM).")); tr("Enable this to save your replays into subfolders by month (YYYY-MM)."));
replay_settings_layout->addWidget(m_enable_monthly_replay_folders_checkbox); replay_settings_layout->addWidget(enable_monthly_replay_folders_checkbox);
m_enable_monthly_replay_folders_checkbox->setChecked( enable_monthly_replay_folders_checkbox->setChecked(
SConfig::GetInstance().m_slippiReplayMonthFolders); SConfig::GetInstance().m_slippiReplayMonthFolders);
connect(m_enable_monthly_replay_folders_checkbox, &QCheckBox::toggled, this, connect(enable_monthly_replay_folders_checkbox, &QCheckBox::toggled, this,
[](bool checked) { SConfig::GetInstance().m_slippiReplayMonthFolders = checked; }); [](bool checked) { SConfig::GetInstance().m_slippiReplayMonthFolders = checked; });
auto* replay_folder_layout = new QGridLayout(); auto* replay_folder_layout = new QGridLayout();
@ -80,14 +80,14 @@ void SlippiPane::CreateLayout()
online_settings->setLayout(online_settings_layout); online_settings->setLayout(online_settings_layout);
layout->addWidget(online_settings); layout->addWidget(online_settings);
m_delay_spin = new QSpinBox(); auto* delay_spin = new QSpinBox();
m_delay_spin->setSizePolicy(QSizePolicy::Fixed, QSizePolicy::Fixed); delay_spin->setSizePolicy(QSizePolicy::Fixed, QSizePolicy::Fixed);
m_delay_spin->setRange(1, 9); delay_spin->setRange(1, 9);
m_delay_spin->setToolTip(tr("Leave this at 2 unless consistently playing on 120+ ping. " delay_spin->setToolTip(tr("Leave this at 2 unless consistently playing on 120+ ping. "
"Increasing this can cause unplayable input delay, and lowering it " "Increasing this can cause unplayable input delay, and lowering it "
"can cause visual artifacts/lag.")); "can cause visual artifacts/lag."));
online_settings_layout->addRow(tr("Delay Frames:"), m_delay_spin); online_settings_layout->addRow(tr("Delay Frames:"), delay_spin);
m_delay_spin->setValue(SConfig::GetInstance().m_slippiOnlineDelay); delay_spin->setValue(SConfig::GetInstance().m_slippiOnlineDelay);
connect(m_delay_spin, qOverload<int>(&QSpinBox::valueChanged), this, connect(delay_spin, qOverload<int>(&QSpinBox::valueChanged), this,
[](int delay) { SConfig::GetInstance().m_slippiOnlineDelay = delay; }); [](int delay) { SConfig::GetInstance().m_slippiOnlineDelay = delay; });
} }

6
Source/Core/DolphinQt/Settings/SlippiPane.h
View file

@ -4,10 +4,7 @@
#include <QWidget> #include <QWidget>
class QCheckBox;
class QLabel;
class QLineEdit; class QLineEdit;
class QSpinBox;
namespace Core namespace Core
{ {
@ -24,8 +21,5 @@ private:
void BrowseReplayFolder(); void BrowseReplayFolder();
void CreateLayout(); void CreateLayout();
QCheckBox* m_enable_replay_save_checkbox;
QCheckBox* m_enable_monthly_replay_folders_checkbox;
QLineEdit* m_replay_folder_edit; QLineEdit* m_replay_folder_edit;
QSpinBox* m_delay_spin;
}; };