From 845fecff22143063e5cd0d3d8da7dbbe69dba42f Mon Sep 17 00:00:00 2001 From: Jordan Woyak Date: Mon, 5 May 2025 19:17:54 -0500 Subject: [PATCH] Common/BitField: Make deleted functions public. --- Source/Core/Common/BitField.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Source/Core/Common/BitField.h b/Source/Core/Common/BitField.h index 9a2e2032a0..9eef80e032 100644 --- a/Source/Core/Common/BitField.h +++ b/Source/Core/Common/BitField.h @@ -119,13 +119,12 @@ template >::type> struct BitField { -private: +public: // This constructor might be considered ambiguous: // Would it initialize the storage or just the bitfield? // Hence, delete it. Use the assignment operator to set bitfield values! BitField(T val) = delete; -public: // Force default constructor to be created // so that we can use this within unions constexpr BitField() = default; @@ -214,18 +213,17 @@ template >::type> struct BitFieldArray { +public: using Ref = BitFieldArrayRef; using ConstRef = BitFieldArrayConstRef; using Iterator = BitFieldArrayIterator; using ConstIterator = BitFieldArrayConstIterator; -private: // This constructor might be considered ambiguous: // Would it initialize the storage or just the bitfield? // Hence, delete it. Use the assignment operator to set bitfield values! BitFieldArray(T val) = delete; -public: // Force default constructor to be created // so that we can use this within unions constexpr BitFieldArray() = default; @@ -238,7 +236,6 @@ public: // code expects that this class is trivially copyable. BitFieldArray& operator=(const BitFieldArray&) = delete; -public: constexpr bool IsSigned() const { return std::is_signed(); } constexpr std::size_t StartBit() const { return position; } constexpr std::size_t NumBits() const { return bits; }