mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-04-27 06:48:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

VideoCommon: Move logging/seen check for unknown opcodes into CommandProcessor

Browse source 
That way, they're in the same place the panic alerts are generated.
This commit is contained in:
Pokechu22 2022-01-22 22:02:20 -08:00
parent 79b2185117
commit 8d7eff2a8a
4 changed files with 28 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Source/Core/VideoCommon/OpcodeDecoding.cpp
View file

@ -32,14 +32,8 @@
namespace OpcodeDecoder
{
static bool s_is_fifo_error_seen = false;
bool g_record_fifo_data = false;
void Init()
{
s_is_fifo_error_seen = false;
}
template <bool is_preprocess>
class RunCallback final : public Callback
{
@ -207,19 +201,7 @@ public:
}
else
{
// Datel software uses 0x01 during startup, and Mario Party 5's Wiggler capsule
// accidentally uses 0x01-0x03 due to sending 4 more vertices than intended.
// Hardware testing indicates that 0x01-0x07 do nothing, so to avoid annoying the user with
// spurious popups, we don't create a panic alert in those cases. Other unknown opcodes
// (such as 0x18) seem to result in hangs.
if (!s_is_fifo_error_seen && opcode > 0x07)
{
CommandProcessor::HandleUnknownOpcode(opcode, data, is_preprocess);
s_is_fifo_error_seen = true;
}
ERROR_LOG_FMT(VIDEO, "FIFO: Unknown Opcode({:#04x} @ {}, preprocessing = {})", opcode,
fmt::ptr(data), is_preprocess ? "yes" : "no");
CommandProcessor::HandleUnknownOpcode(opcode, data, is_preprocess);
m_cycles += 1;
}
}