From a07d19a2fd1e6a06db56649f4ae6233a358e80dd Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Wed, 31 Jul 2019 09:44:16 -0400
Subject: [PATCH] DolphinQt/Config/ARCodeWidget: Use forward declarations where
 applicable

Avoids propagating headers into scopes where they're not necessary.

Also uncovered reliance on an indirect inclusion within
CheatsManager.cpp, which is now fixed.
---
 Source/Core/DolphinQt/CheatsManager.cpp       | 1 +
 Source/Core/DolphinQt/Config/ARCodeWidget.cpp | 2 ++
 Source/Core/DolphinQt/Config/ARCodeWidget.h   | 7 ++++++-
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/Source/Core/DolphinQt/CheatsManager.cpp b/Source/Core/DolphinQt/CheatsManager.cpp
index fda9adb909..11daa9d97a 100644
--- a/Source/Core/DolphinQt/CheatsManager.cpp
+++ b/Source/Core/DolphinQt/CheatsManager.cpp
@@ -21,6 +21,7 @@
 #include <QTableWidget>
 #include <QVBoxLayout>
 
+#include "Core/ActionReplay.h"
 #include "Core/ConfigManager.h"
 #include "Core/Core.h"
 #include "Core/Debugger/PPCDebugInterface.h"
diff --git a/Source/Core/DolphinQt/Config/ARCodeWidget.cpp b/Source/Core/DolphinQt/Config/ARCodeWidget.cpp
index 6fbfcb4906..7120eaab8a 100644
--- a/Source/Core/DolphinQt/Config/ARCodeWidget.cpp
+++ b/Source/Core/DolphinQt/Config/ARCodeWidget.cpp
@@ -43,6 +43,8 @@ ARCodeWidget::ARCodeWidget(const UICommon::GameFile& game, bool restart_required
   OnSelectionChanged();
 }
 
+ARCodeWidget::~ARCodeWidget() = default;
+
 void ARCodeWidget::CreateWidgets()
 {
   m_warning = new CheatWarningWidget(m_game_id, m_restart_required, this);
diff --git a/Source/Core/DolphinQt/Config/ARCodeWidget.h b/Source/Core/DolphinQt/Config/ARCodeWidget.h
index a95044645d..48af85ec22 100644
--- a/Source/Core/DolphinQt/Config/ARCodeWidget.h
+++ b/Source/Core/DolphinQt/Config/ARCodeWidget.h
@@ -10,7 +10,11 @@
 #include <vector>
 
 #include "Common/CommonTypes.h"
-#include "Core/ActionReplay.h"
+
+namespace ActionReplay
+{
+struct ARCode;
+}
 
 namespace UICommon
 {
@@ -28,6 +32,7 @@ class ARCodeWidget : public QWidget
   Q_OBJECT
 public:
   explicit ARCodeWidget(const UICommon::GameFile& game, bool restart_required = true);
+  ~ARCodeWidget() override;
 
   void AddCode(ActionReplay::ARCode code);