From c564d6410402d93dc81ed146e09657e434722e46 Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Fri, 15 Nov 2019 16:41:33 -0800 Subject: [PATCH] Remove unused drive debug command constants The corresponding code that used these was removed in 2009 with 93b83f8d659. Now their only purpose is to generate warnings on osx. Minimalistic documentation on these commands can be found at http://hitmen.c02.at/files/yagcd/yagcd/chap5.html#sec5.7.2 and https://web.archive.org/web/20070328200323/http://tmb.elitedvb.net/dvd-game/index.php/CMDFE. Those constants only relate to the 0x11 subcommand, which is one of many. Most can't be properly emulated unless we LLE the drive firmware (in which case, they don't need to be reimplemented). --- Source/Core/Core/HW/DVD/DVDInterface.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/Source/Core/Core/HW/DVD/DVDInterface.cpp b/Source/Core/Core/HW/DVD/DVDInterface.cpp index 498de9b42c..5a797d0dd5 100644 --- a/Source/Core/Core/HW/DVD/DVDInterface.cpp +++ b/Source/Core/Core/HW/DVD/DVDInterface.cpp @@ -98,12 +98,6 @@ constexpr u32 DI_DMA_CONTROL_REGISTER = 0x1C; constexpr u32 DI_IMMEDIATE_DATA_BUFFER = 0x20; constexpr u32 DI_CONFIG_REGISTER = 0x24; -// debug commands which may be ORd -constexpr u32 STOP_DRIVE = 0; -constexpr u32 START_DRIVE = 0x100; -constexpr u32 ACCEPT_COPY = 0x4000; -constexpr u32 DISC_CHECK = 0x8000; - // DI Status Register union UDISR {