From 267e6608d325645f9a10ea98f1ca5b67bdb90ad2 Mon Sep 17 00:00:00 2001 From: Nitch2024 Date: Wed, 26 Mar 2025 13:22:39 -0700 Subject: [PATCH] Fixing lint and reported CI errors --- Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp | 5 +---- Source/Core/DolphinQt/Debugger/MemoryWidget.cpp | 9 +++++---- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp b/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp index 4e7abb9e13..e11dfeb5bc 100644 --- a/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp @@ -1060,10 +1060,7 @@ void CodeViewWidget::DoPatchInstruction(bool assemble) if (assemble) { - std::string code_line = [this, addr] { - Core::CPUThreadGuard guard(m_system); - return m_system.GetPowerPC().GetDebugInterface().Disassemble(&guard, addr); - }(); + std::string code_line = m_system.GetPowerPC().GetDebugInterface().Disassemble(&guard, addr); std::ranges::replace(code_line, '\t', ' ' ); diff --git a/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp b/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp index 10f9c1a818..d551bca225 100644 --- a/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp @@ -168,7 +168,7 @@ void MemoryWidget::CreateWidgets() m_result_label = new QLabel; auto* search_bp_group = new QHBoxLayout; - auto *auto_bp_label = new QLabel(tr("Auto BP")); + auto* auto_bp_label = new QLabel(tr("Auto BP")); m_find_auto_mem_bp = new QCheckBox(tr("Mem")); m_find_auto_code_bp = new QCheckBox(tr("Code")); search_bp_group->addWidget(auto_bp_label); @@ -366,7 +366,7 @@ void MemoryWidget::ConnectWidgets() { connect(radio, &QRadioButton::toggled, this, &MemoryWidget::OnAddressSpaceChanged); } - for (auto* combo : {m_display_combo, m_align_combo, m_row_length_combo, m_find_align }) + for (auto* combo : {m_display_combo, m_align_combo, m_row_length_combo, m_find_align}) { connect(combo, &QComboBox::currentIndexChanged, this, &MemoryWidget::OnDisplayChanged); } @@ -383,7 +383,8 @@ void MemoryWidget::ConnectWidgets() connect(m_memory_view, &MemoryViewWidget::ShowCode, this, &MemoryWidget::ShowCode); connect(m_memory_view, &MemoryViewWidget::RequestWatch, this, &MemoryWidget::RequestWatch); - connect(m_memory_view, &MemoryViewWidget::ActivateSearch, this, &MemoryWidget::ActivateSearchAddress); + connect(m_memory_view, &MemoryViewWidget::ActivateSearch, this, + &MemoryWidget::ActivateSearchAddress); } void MemoryWidget::closeEvent(QCloseEvent*) @@ -949,7 +950,7 @@ void MemoryWidget::OnFindNextValue() { m_memory_view->ToggleBreakpoint(m_memory_view->GetAddress(), false); } - if (set_code_bp && ( 4 <= alignment ) ) + if (set_code_bp && (4 <= alignment)) { m_system.GetPowerPC().GetBreakPoints().ToggleBreakPoint(m_memory_view->GetAddress()); emit Host::GetInstance()->PPCBreakpointsChanged();