mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-08-02 06:08:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

AchievementManager: Make GetInstance() return a reference

Browse source 
The internal static member will always have a valid lifetime. Makes this
consistent with other instance based objects in our code.
This commit is contained in:
Lioncash 2023-12-11 13:18:02 -05:00
commit e55f9ed102
21 changed files with 81 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Source/Core/DolphinQt/MenuBar.cpp
View file

@ -125,7 +125,7 @@ void MenuBar::OnEmulationStateChanged(Core::State state)
m_state_save_menu->setEnabled(running);
#ifdef USE_RETRO_ACHIEVEMENTS
bool hardcore = AchievementManager::GetInstance()->IsHardcoreModeActive();
const bool hardcore = AchievementManager::GetInstance().IsHardcoreModeActive();
m_state_load_menu->setEnabled(running && !hardcore);
m_frame_advance_action->setEnabled(running && !hardcore);
#else // USE_RETRO_ACHIEVEMENTS