mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-08-10 10:08:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

VideoCommon/RenderBase: Use a std::string_view with CreateShaderFromSource()

Browse source 
Greatly simplifies the overall interface when it comes to compiling
shaders. Also allows getting rid of a std::string overload of the same
name. Now std::string and const char* both go through the same function.
This commit is contained in:
Lioncash 2019-05-30 03:07:40 -04:00
commit e60268bd42
25 changed files with 94 additions and 117 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Source/Core/VideoBackends/D3D/Render.cpp
View file

@ -113,10 +113,10 @@ std::unique_ptr<AbstractFramebuffer> Renderer::CreateFramebuffer(AbstractTexture
}
std::unique_ptr<AbstractShader> Renderer::CreateShaderFromSource(ShaderStage stage,
const char* source, size_t length)
std::string_view source)
{
DXShader::BinaryData bytecode;
if (!DXShader::CompileShader(D3D::feature_level, &bytecode, stage, source, length))
if (!DXShader::CompileShader(D3D::feature_level, &bytecode, stage, source))
return nullptr;
return DXShader::CreateFromBytecode(stage, std::move(bytecode));