mirrors/dolphin
0
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-31 13:18:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Software: Remove normalization special case

Browse source 
The special case doesn't appear to make a significant difference in any games, and the current implementation has a (minor, fixable) issue that breaks Super Mario Sunshine (both with a failed assertion (https://bugs.dolphin-emu.org/issues/11742) and a rendering issue (https://bugs.dolphin-emu.org/issues/7476)).  Hardware testing wasn't able to reproduce the special case, either, so it may just not exist.

PR #9315 contains a fixed implementation of the special case on all video backends, and can serve as a basis for it being reintroduced if it is found to exist under more specific circumstances.  For now, I don't see a reason to keep it present.
This commit is contained in:
Pokechu22 2021-01-03 23:22:48 -08:00
commit e825af7b1b
4 changed files with 10 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Source/Core/VideoBackends/Software/SWVertexLoader.h
View file

@ -28,6 +28,4 @@ protected:
InputVertexData m_vertex;
SetupUnit m_setup_unit;
bool m_tex_gen_special_case;
};