Dentomologist
e37a195192
MainWindow: Fix use-after-free during shutdown
...
Remove ConfigChangedCallback in MainWindow's destructor to prevent the
callback from accessing the destroyed MainWindow afterward.
After MainWindow is destroyed UICommon::Shutdown calls
LogManager::Shutdown which ultimately triggers any remaining callbacks.
This resulted in calling MainWindow::OnHardcoreChanged, which crashed in
debug builds and didn't have any obvious effect in release builds.
2025-04-25 15:29:29 -07:00
Dr. Dystopia
9868138c22
UCodes: Remove redundant qualifiers
2025-04-25 13:18:56 +02:00
Dr. Dystopia
066408326c
Core/HW/EXI: Remove redundant inline
specifiers
2025-04-25 12:03:52 +02:00
Dr. Dystopia
50ca32352f
Core/HW/GCMemcard: Make variables constant
2025-04-25 11:35:59 +02:00
Tilka
805307f432
Merge pull request #13451 from vyuuui/numeric_labels
...
Add numeric label support to assembler
2025-04-25 01:56:43 +01:00
Tilka
fe307a06c6
Merge pull request #13476 from jordan-woyak/sdl-header
...
InputCommon: Move SDL Device class into its own cpp/h files.
2025-04-25 01:49:52 +01:00
Tilka
a95779add0
Merge pull request #13506 from JosJuice/android-time-played
...
Android: Show time played in game details
2025-04-25 01:43:53 +01:00
Tilka
5523b9a01b
Merge pull request #13487 from Dentomologist/performancemetrics_fix_window_arrangement
...
PerformanceMetrics: Fix window arrangement
2025-04-25 01:40:58 +01:00
Tilka
50026ab795
Merge pull request #13497 from hoogmin/modernize_fs_path
...
Core/Common/FileUtil.cpp: Use std path utility for automatic path separator handling.
2025-04-25 01:38:35 +01:00
Tillmann Karras
a6290caa2e
DSPHLE: set accelerator gain
2025-04-25 01:09:15 +01:00
Tillmann Karras
80adfc606d
docs/DSP: Rename SCALE to PRED_SCALE
2025-04-25 01:09:15 +01:00
Tillmann Karras
8412a7c336
DSPAccelerator: update comment (NFC)
2025-04-25 01:09:15 +01:00
Tillmann Karras
f0bacb826a
DSPAccelerator: rename MMIOPCMHalt to MMIOPCMNoInc
2025-04-25 01:09:15 +01:00
Tillmann Karras
7c7c179b44
DSP tests: update DSP MMIO labels
2025-04-25 00:51:46 +01:00
Tillmann Karras
6c870860ea
DSP tests: clean up unused code
2025-04-25 00:51:46 +01:00
Tillmann Karras
05381c5b6d
Address Pokechu22's feedback
2025-04-25 00:51:46 +01:00
xperia64
21d5e3182d
Fix DSP loop test init order, add DSP pcm test
2025-04-25 00:51:46 +01:00
xperia64
cd77e682ca
Name gain shift/scaling better
2025-04-25 00:51:46 +01:00
xperia64
512da86b1a
Update DSP docs with accelerator info, fix ANDC/ORC instruction description typos
2025-04-25 00:51:46 +01:00
xperia64
c460cafecf
Update ACDRAW/ACDSAMP reg names in DSPTables and DSPSpy tests
2025-04-25 00:51:46 +01:00
xperia64
d517fe25f1
Add accelerator input MMIO register, fix MMIO PCM modes
2025-04-25 00:51:45 +01:00
xperia64
14fadbbe56
ADPCM mode doesn't entirely die with larger accesses, gain is PCM only
2025-04-25 00:51:45 +01:00
xperia64
c7d8afc5a7
Use correct exceptions for d3 reads/writes
2025-04-25 00:51:45 +01:00
xperia64
c9bb258e88
Add accelerator raw d3 test
2025-04-25 00:51:45 +01:00
xperia64
0dd282f626
Fix DSPAcceleratorTest
2025-04-25 00:51:45 +01:00
xperia64
ac2fdefcb4
Refactor accelerator format as a bitfield, use gain/yn1/yn2 in PCM mode
2025-04-25 00:51:45 +01:00
xperia64
04c7c1a4a1
Rename accelerator accesses to 'raw' and 'sample'
2025-04-25 00:51:45 +01:00
xperia64
256d9f8702
Improve ReadD3 emulation
2025-04-25 00:51:45 +01:00
xperia64
bbc11edd7d
Rework WriteD3 based on hardware testing
2025-04-25 00:51:45 +01:00
Tillmann Karras
4d9dc1e1cd
GekkoDisassembler: standardize SPR names and add missing ones
2025-04-25 00:24:12 +01:00
JosJuice
908094714b
Translation resources sync with Transifex
2025-04-24 23:38:09 +02:00
Dr. Dystopia
ef8b9a0dcd
Core/HW/SI: Make variables constant
2025-04-24 17:01:12 +02:00
JMC47
8fa725d5e4
Merge pull request #13573 from tygyh/DolphinTool-Make-parameter-constant
...
DolphinTool: Make parameter constant
2025-04-24 00:49:10 -04:00
JMC47
fc0aafca3b
Merge pull request #13577 from tygyh/UCodes-Make-functions-static
...
UCodes: Make functions static
2025-04-24 00:48:46 -04:00
JMC47
f675048768
Merge pull request #13578 from tygyh/Core/HW-Remove-redundant-empty-lambda-parameter-lists
...
Core/HW: Remove redundant empty lambda parameter lists
2025-04-24 00:48:28 -04:00
Jordan Woyak
1cea31c75a
Merge pull request #13580 from LillyJadeKatrin/retroachievements-de-bug-debug
...
Fix debugger disabled bug
2025-04-23 23:28:19 -05:00
Jordan Woyak
3025cd472c
Merge pull request #13491 from JosJuice/oh0-removed-opened
...
IOS: Remove from m_opened_devices in OH0::OnDeviceChange
2025-04-23 23:25:34 -05:00
LillyJadeKatrin
022bc3bf8d
Fix debugger disabled bug
...
Fixing an oversight: this was causing the debugger to be disabled if achievements were disabled but hardcore mode was still enabled in the .ini. This fix properly checks for hardcore state via AchievementManager which takes both settings into account.
2025-04-23 22:57:35 -04:00
Admiral H. Curtiss
879a8889aa
Merge pull request #13431 from jordan-woyak/spsc-waiting
...
Common: SPSCQueue cleanups and improvements.
2025-04-23 22:19:15 +02:00
Dr. Dystopia
564e7c3320
UCodes: Make functions static
2025-04-23 21:36:13 +02:00
Dr. Dystopia
467a568f60
Core/HW: Remove redundant empty lambda parameter lists
2025-04-23 21:32:09 +02:00
Jordan Woyak
6c751fb722
Merge pull request #13570 from SuperSamus/advanced-panel-unused
...
DolphinQt: Remove unused variables from `AdvancedPane.h`
2025-04-23 13:30:39 -05:00
Dr. Dystopia
03a6fdcd85
DolphinTool: Make variables constant
2025-04-23 20:24:50 +02:00
JosJuice
bda1f379b7
IOS: Remove from m_opened_devices in OH0::OnDeviceChange
...
I've been playing Rock Band 3 recently and have experienced a bug where
sometimes if you disconnect and reconnect a USB microphone, the game
won't pick up on it connecting, not even it you disconnect and reconnect
it again. An investigation into what's going on inside Dolphin shows
that when the game triggers a call to OH0::DeviceOpen after the device
has been reinserted, Dolphin doesn't open the device because it's
already present in m_opened_devices.
Removing the device from m_opened_devices after calling OH0::TriggerHook
in OH0::OnDeviceChange resolves this specific issue in my testing. Doing
this matches us removing the device from m_opened_devices after calling
OH0::TriggerHook in OH0::DeviceClose, but I haven't looked at exactly
what real IOS does.
I have been able to reproduce a much rarer issue that has the same
symptoms on the surface but where OH0::DeviceOpen gets past its
m_opened_devices check. I'm currently not sure what the cause of this
remaining issue is.
2025-04-23 17:19:14 +02:00
JosJuice
c44418a4d9
Merge pull request #13561 from JosJuice/android-renumbered-platforms
...
Android: Update platform enum values
2025-04-23 17:08:50 +02:00
Dr. Dystopia
fe657b9759
DolphinTool: Make parameter constant
2025-04-23 15:55:48 +02:00
Dr. Dystopia
d5314cbf48
UnitTests: Remove redundant virtual
specifier
2025-04-23 14:33:14 +02:00
Dr. Dystopia
9926a9bd7f
VertexLoaderTest: Replace std::tie
with structured bindings
2025-04-23 13:11:17 +02:00
Dr. Dystopia
947bdea590
UnitTests: Use constexpr
2025-04-23 12:45:08 +02:00
Martino Fontana
e751235574
DolphinQt: Remove unused variables from AdvancedPane.h
...
Small oversight from #13422 .
2025-04-23 12:32:12 +02:00