mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-04-27 14:58:32 +00:00
bd3cf67cbc
Before: 1. In theory there could be multiple, but in practice they were (manually) cleared before creating one 2. (Some of) the conditions to clear one were either to reach it, to create a new one (due to the point above), or to step. This created weird behavior: let's say you Step Over a `bl` (thus creating a temporary breakpoint on `pc+4`), and you reached a regular breakpoint inside the `bl`. The temporary one would still be there: if you resumed, the emulation would still stop there, as a sort of Step Out. But, if before resuming, you made a Step, then it wouldn't do that. 3. The breakpoint widget had no idea concept of them, and will treat them as regular breakpoints. Also, they'll be shown only when the widget is updated in some other way, leading to more confusion. 4. Because only one breakpoint could exist per address, the creation of a temporary breakpoint on a top of a regular one would delete it and inherit its properties (e.g. being log-only). This could happen, for instance, if you Stepped Over a `bl` specifically, and pc+4 had a regular breakpoint. Now there can only be one temporary breakpoint, which is automatically cleared whenever emulation is paused. So, removing some manual clearing from 1., and removing the weird behavior of 2. As it is stored in a separate variable, it won't be seen at all depending on the function used (fixing 3., and removing some checks in other places), and it won't replace a regular breakpoint, instead simply having priority (fixing 4.). |
||
|---|---|---|
| .. | ||
| AssembleInstructionDialog.cpp | ||
| AssembleInstructionDialog.h | ||
| AssemblerWidget.cpp | ||
| AssemblerWidget.h | ||
| AssemblyEditor.cpp | ||
| AssemblyEditor.h | ||
| BranchWatchDialog.cpp | ||
| BranchWatchDialog.h | ||
| BranchWatchTableModel.cpp | ||
| BranchWatchTableModel.h | ||
| BreakpointDialog.cpp | ||
| BreakpointDialog.h | ||
| BreakpointWidget.cpp | ||
| BreakpointWidget.h | ||
| CodeViewWidget.cpp | ||
| CodeViewWidget.h | ||
| CodeWidget.cpp | ||
| CodeWidget.h | ||
| GekkoSyntaxHighlight.cpp | ||
| GekkoSyntaxHighlight.h | ||
| JITWidget.cpp | ||
| JITWidget.h | ||
| MemoryViewWidget.cpp | ||
| MemoryViewWidget.h | ||
| MemoryWidget.cpp | ||
| MemoryWidget.h | ||
| NetworkWidget.cpp | ||
| NetworkWidget.h | ||
| PatchInstructionDialog.cpp | ||
| PatchInstructionDialog.h | ||
| RegisterColumn.cpp | ||
| RegisterColumn.h | ||
| RegisterWidget.cpp | ||
| RegisterWidget.h | ||
| ThreadWidget.cpp | ||
| ThreadWidget.h | ||
| WatchWidget.cpp | ||
| WatchWidget.h | ||