mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-06-19 08:41:39 +00:00
6d8ba94e4c
Gecko codes in Dolphin feature a dedicated field for the creator of the cheat code. When saved into the INI file, the code name and the creator name are concatenated, and then inserted in the `[Gecko]` section: ```ini [Gecko] $<cheat code name> [<creator>] <code line 1> <code line 2> <code line 3> <...> $<other cheat code name> [<creator>] <code line 1> <code line 2> <code line 3> <...> ``` On the other hand, enabled codes are listed under the `[Gecko_Enabled]` section, but in this case the creator name is omitted from the line: ```ini [Gecko_Enabled] $<cheat code name> $<other cheat code name> ``` Having the creator name in the `[Gecko]` section but not in the `[Gecko_Enabled]` section is arguably not ideal, but this is legacy behavior in Dolphin. The **Cheat Code Editor** dialog is not acknowledging this subtle behavior in Dolphin: the cheat code name and the creator name *can* be both inserted in the name field. This issue manifests as an inconsistent state where a Gecko code that *appears* to be enabled has no effect when the game is launched. As part of this fix, the creator name (if present) is now moved into the dedicated creator field before the code is stored internally. Test plan: - Right-click on any game and open the **Properties** dialog. - Switch to the **Gecko Codes** tab. - Press the **Add New Code...** button. - In the **Cheat Code Editor** dialog: - Enter `This is a test [Jane Doe]` in the **Name:** field. - Enter `01234567 00000000` in the **Code:** field. - Press **Save**. - Observe that the newly added code is now in the list, and *appears* to be enabled. - Close the **Properties** dialog. - Right-click on the same game and open the **Properties** dialog again. **Without** the fix, the newly added code, while still on the list, has been inadvertently disabled (it was never really enabled!). **With** the fix, the newly added code is the list and remains enabled. This fixes https://bugs.dolphin-emu.org/issues/13695. |
||
|---|---|---|
| .. | ||
| ConfigControls | ||
| ControllerInterface | ||
| Graphics | ||
| Mapping | ||
| ToolTipControls | ||
| ARCodeWidget.cpp | ||
| ARCodeWidget.h | ||
| CheatCodeEditor.cpp | ||
| CheatCodeEditor.h | ||
| CheatWarningWidget.cpp | ||
| CheatWarningWidget.h | ||
| CommonControllersWidget.cpp | ||
| CommonControllersWidget.h | ||
| ControllersWindow.cpp | ||
| ControllersWindow.h | ||
| FilesystemWidget.cpp | ||
| FilesystemWidget.h | ||
| FreeLookWidget.cpp | ||
| FreeLookWidget.h | ||
| FreeLookWindow.cpp | ||
| FreeLookWindow.h | ||
| GameConfigEdit.cpp | ||
| GameConfigEdit.h | ||
| GameConfigHighlighter.cpp | ||
| GameConfigHighlighter.h | ||
| GameConfigWidget.cpp | ||
| GameConfigWidget.h | ||
| GamecubeControllersWidget.cpp | ||
| GamecubeControllersWidget.h | ||
| GeckoCodeWidget.cpp | ||
| GeckoCodeWidget.h | ||
| GraphicsModListWidget.cpp | ||
| GraphicsModListWidget.h | ||
| GraphicsModWarningWidget.cpp | ||
| GraphicsModWarningWidget.h | ||
| HardcoreWarningWidget.cpp | ||
| HardcoreWarningWidget.h | ||
| InfoWidget.cpp | ||
| InfoWidget.h | ||
| LogConfigWidget.cpp | ||
| LogConfigWidget.h | ||
| LogWidget.cpp | ||
| LogWidget.h | ||
| NewPatchDialog.cpp | ||
| NewPatchDialog.h | ||
| PatchesWidget.cpp | ||
| PatchesWidget.h | ||
| PropertiesDialog.cpp | ||
| PropertiesDialog.h | ||
| SettingsWindow.cpp | ||
| SettingsWindow.h | ||
| VerifyWidget.cpp | ||
| VerifyWidget.h | ||
| WiimoteControllersWidget.cpp | ||
| WiimoteControllersWidget.h | ||