From 196e55899e970e9749c71c588c5a01f46ca28761 Mon Sep 17 00:00:00 2001
From: Koen J <koen@disper.io>
Date: Thu, 21 Nov 2024 17:25:18 +0100
Subject: [PATCH] Fixed DASH generation with subtitles.

---
 .../java/com/futo/platformplayer/builders/DashBuilder.kt   | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/com/futo/platformplayer/builders/DashBuilder.kt b/app/src/main/java/com/futo/platformplayer/builders/DashBuilder.kt
index 98593848..629f4da5 100644
--- a/app/src/main/java/com/futo/platformplayer/builders/DashBuilder.kt
+++ b/app/src/main/java/com/futo/platformplayer/builders/DashBuilder.kt
@@ -88,7 +88,8 @@ class DashBuilder : XMLBuilder {
     fun withRepresentationOnDemand(id: String, subtitleSource: ISubtitleSource, subtitleUrl: String) {
         withRepresentation(id, mapOf(
             Pair("mimeType", subtitleSource.format ?: "text/vtt"),
-            Pair("startWithSAP", "1"),
+            Pair("default", "true"),
+            Pair("lang", "en"),
             Pair("bandwidth", "1000")
         )) {
             it.withBaseURL(subtitleUrl)
@@ -151,7 +152,7 @@ class DashBuilder : XMLBuilder {
                     )
                 ) {
                     //TODO: Verify if & really should be replaced like this?
-                    it.withRepresentationOnDemand("1", subtitleSource, subtitleUrl.replace("&", "&amp;"))
+                    it.withRepresentationOnDemand("caption_en", subtitleSource, subtitleUrl.replace("&", "&amp;"))
                 }
             }
             //Video
@@ -164,7 +165,7 @@ class DashBuilder : XMLBuilder {
                         Pair("subsegmentStartsWithSAP", "1")
                     )
                 ) {
-                    it.withRepresentationOnDemand("1", vidSource, vidUrl.replace("&", "&amp;"));
+                    it.withRepresentationOnDemand("2", vidSource, vidUrl.replace("&", "&amp;"));
                 }
             }