From 003c045589dc4b2904bfba884a4c5b1012e436e8 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 23 Jan 2025 17:38:24 +0100 Subject: [PATCH] LibWeb: Add missing base class upcalls in Node::inserted() overrides --- Libraries/LibWeb/HTML/HTMLDetailsElement.cpp | 2 ++ Libraries/LibWeb/HTML/HTMLMeterElement.cpp | 1 + Libraries/LibWeb/HTML/HTMLProgressElement.cpp | 1 + 3 files changed, 4 insertions(+) diff --git a/Libraries/LibWeb/HTML/HTMLDetailsElement.cpp b/Libraries/LibWeb/HTML/HTMLDetailsElement.cpp index 6b6ac1688cc..46c91a21bad 100644 --- a/Libraries/LibWeb/HTML/HTMLDetailsElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLDetailsElement.cpp @@ -45,6 +45,8 @@ void HTMLDetailsElement::initialize(JS::Realm& realm) // https://html.spec.whatwg.org/multipage/interactive-elements.html#the-details-element:html-element-insertion-steps void HTMLDetailsElement::inserted() { + Base::inserted(); + // 1. Ensure details exclusivity by closing the given element if needed given insertedNode. ensure_details_exclusivity_by_closing_the_given_element_if_needed(); diff --git a/Libraries/LibWeb/HTML/HTMLMeterElement.cpp b/Libraries/LibWeb/HTML/HTMLMeterElement.cpp index 28c75e7da87..852190114bd 100644 --- a/Libraries/LibWeb/HTML/HTMLMeterElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLMeterElement.cpp @@ -170,6 +170,7 @@ WebIDL::ExceptionOr HTMLMeterElement::set_optimum(double value) void HTMLMeterElement::inserted() { + Base::inserted(); create_shadow_tree_if_needed(); } diff --git a/Libraries/LibWeb/HTML/HTMLProgressElement.cpp b/Libraries/LibWeb/HTML/HTMLProgressElement.cpp index ab8e31c958a..6662d7c6502 100644 --- a/Libraries/LibWeb/HTML/HTMLProgressElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLProgressElement.cpp @@ -92,6 +92,7 @@ double HTMLProgressElement::position() const void HTMLProgressElement::inserted() { + Base::inserted(); create_shadow_tree_if_needed(); }