From 00936e151ee1106de0e77ff938537a54740daed1 Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Tue, 9 Aug 2022 20:17:42 -0700 Subject: [PATCH] Kernel: Make failure to write coredump or perfcore a regular dmesg This does not need to be a critical dmesg, as the system stays up it makes more sense for it to be a normal dmesg message. Luke mentioned this on discord, they really deserve the credit :^) Reported-by: Luke Wilde --- Kernel/Process.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp index 78743d390ac..38b82655ffd 100644 --- a/Kernel/Process.cpp +++ b/Kernel/Process.cpp @@ -627,13 +627,13 @@ void Process::finalize() if (m_should_generate_coredump) { auto result = dump_core(); if (result.is_error()) { - critical_dmesgln("Failed to write coredump: {}", result.error()); + dmesgln("Failed to write coredump for pid {}: {}", pid(), result.error()); } } if (m_perf_event_buffer) { auto result = dump_perfcore(); if (result.is_error()) - critical_dmesgln("Failed to write perfcore: {}", result.error()); + dmesgln("Failed to write perfcore for pid {}: {}", pid(), result.error()); TimeManagement::the().disable_profile_timer(); } }