mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-23 21:15:14 +00:00
Revert "CI: Only run builds after successful linting"
This reverts commitsbf333eaea2
and6f69a445bd
. The commit linter needs to run on event `pull_request_target` to have access to its secret token, which means we cannot have a dependency on that job from another workflow that is run as a result of the `pull_request` event. Additionally, the linters were no longer run for first-time contributors. This isn't a huge problem but it was nice that a preliminary check took place before running the full CI on their PRs.
This commit is contained in:
parent
357eeba49c
commit
01031bcccb
Notes:
github-actions[bot]
2025-03-20 23:03:36 +00:00
Author: https://github.com/gmta Commit: https://github.com/LadybirdBrowser/ladybird/commit/01031bcccb6 Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4026
3 changed files with 3 additions and 19 deletions
16
.github/workflows/ci.yml
vendored
16
.github/workflows/ci.yml
vendored
|
@ -7,23 +7,9 @@ concurrency:
|
|||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
lint_code:
|
||||
name: 'Lint Code'
|
||||
uses: ./.github/workflows/lint-code.yml
|
||||
|
||||
lint_commits:
|
||||
name: 'Lint Commits'
|
||||
if: ${{ github.event_name == 'pull_request' }}
|
||||
uses: ./.github/workflows/lint-commits.yml
|
||||
|
||||
# CI matrix - runs the job in lagom-template.yml with different configurations.
|
||||
Lagom:
|
||||
needs: [lint_code, lint_commits]
|
||||
if: |
|
||||
always()
|
||||
&& github.repository == 'LadybirdBrowser/ladybird'
|
||||
&& needs.lint_code.result == 'success'
|
||||
&& (needs.lint_commits.result == 'skipped' || needs.lint_commits.result == 'success')
|
||||
if: github.repository == 'LadybirdBrowser/ladybird'
|
||||
|
||||
strategy:
|
||||
fail-fast: false
|
||||
|
|
3
.github/workflows/lint-code.yml
vendored
3
.github/workflows/lint-code.yml
vendored
|
@ -1,7 +1,6 @@
|
|||
name: Lint Code
|
||||
|
||||
# Used by ci.yml
|
||||
on: [workflow_call]
|
||||
on: [ push, pull_request ]
|
||||
|
||||
jobs:
|
||||
lint:
|
||||
|
|
3
.github/workflows/lint-commits.yml
vendored
3
.github/workflows/lint-commits.yml
vendored
|
@ -1,7 +1,6 @@
|
|||
name: Lint Commit Messages
|
||||
|
||||
# Used by ci.yml
|
||||
on: [workflow_call]
|
||||
on: [pull_request_target]
|
||||
|
||||
# Make sure to update Meta/lint-commit.sh to match this script when adding new checks!
|
||||
# (… but don't accept overlong 'fixup!' commit descriptions.)
|
||||
|
|
Loading…
Add table
Reference in a new issue