mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 04:39:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Perform DOMTokenList token validation in the correct order

Browse source
This commit is contained in:
Tim Ledbetter 2024-07-23 13:10:50 +01:00 • committed by Andreas Kling
commit 0127190dcf
Notes: github-actions[bot] 2024-07-25 04:44:23 +00:00
4 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibWeb/DOM/DOMTokenList.cpp
View file

@ -192,9 +192,12 @@ WebIDL::ExceptionOr<bool> DOMTokenList::toggle(String const& token, Optional<boo
WebIDL::ExceptionOr<bool> DOMTokenList::replace(String const& token, String const& new_token)
{
// 1. If either token or newToken is the empty string, then throw a "SyntaxError" DOMException.
TRY(validate_token_not_empty(token));
TRY(validate_token_not_empty(new_token));
// 2. If either token or newToken contains any ASCII whitespace, then throw an "InvalidCharacterError" DOMException.
TRY(validate_token(token));
TRY(validate_token(new_token));
TRY(validate_token_not_whitespace(token));
TRY(validate_token_not_whitespace(new_token));
// 3. If this’s token set does not contain token, then return false.
if (!contains(token))
@ -264,9 +267,21 @@ void DOMTokenList::set_value(String const& value)
}
WebIDL::ExceptionOr<void> DOMTokenList::validate_token(StringView token) const
{
TRY(validate_token_not_empty(token));
TRY(validate_token_not_whitespace(token));
return {};
}
WebIDL::ExceptionOr<void> DOMTokenList::validate_token_not_empty(StringView token) const
{
if (token.is_empty())
return WebIDL::SyntaxError::create(realm(), "Non-empty DOM tokens are not allowed"_fly_string);
return {};
}
WebIDL::ExceptionOr<void> DOMTokenList::validate_token_not_whitespace(StringView token) const
{
if (any_of(token, Infra::is_ascii_whitespace))
return WebIDL::InvalidCharacterError::create(realm(), "DOM tokens containing ASCII whitespace are not allowed"_fly_string);
return {};