mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-22 10:19:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Implement PopoverInvokerElement attribute change steps

Browse source 
PopoverInvokerElement's explicitly set attr-element should be set to
null whenever the value of the `popovertarget` content attribute is
changed.
This commit is contained in:
Tim Ledbetter 2024-12-12 19:53:04 +00:00 • committed by Tim Flynn
commit 022141647a
Notes: github-actions[bot] 2024-12-14 20:12:21 +00:00
7 changed files with 101 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/HTML/HTMLButtonElement.cpp
View file

@ -45,6 +45,11 @@ WebIDL::ExceptionOr<void> HTMLButtonElement::set_type(String const& type)
return set_attribute(HTML::AttributeNames::type, type);
}
void HTMLButtonElement::form_associated_element_attribute_changed(FlyString const& name, Optional<String> const& value, Optional<FlyString> const& namespace_)
{
PopoverInvokerElement::associated_attribute_changed(name, value, namespace_);
}
void HTMLButtonElement::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);

2
Libraries/LibWeb/HTML/HTMLButtonElement.h
View file

@ -40,6 +40,8 @@ public:
TypeAttributeState type_state() const;
WebIDL::ExceptionOr<void> set_type(String const&);
virtual void form_associated_element_attribute_changed(FlyString const& name, Optional<String> const& value, Optional<FlyString> const& namespace_) override;
// ^EventTarget
// https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-button-element
// https://html.spec.whatwg.org/multipage/interaction.html#focusable-area

32
Libraries/LibWeb/HTML/PopoverInvokerElement.cpp Normal file
View file

@ -0,0 +1,32 @@
/*
* Copyright (c) 2024, Tim Ledbetter <tim.ledbetter@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/DOM/Element.h>
#include <LibWeb/HTML/AttributeNames.h>
#include <LibWeb/HTML/PopoverInvokerElement.h>
namespace Web::HTML {
void PopoverInvokerElement::associated_attribute_changed(FlyString const& name, Optional<String> const&, Optional<FlyString> const& namespace_)
{
// From: https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#reflecting-content-attributes-in-idl-attributess
// For element reflected targets only: the following attribute change steps, given element, localName, oldValue, value, and namespace,
// are used to synchronize between the content attribute and the IDL attribute:
// 1. If localName is not attr or namespace is not null, then return.
if (name != HTML::AttributeNames::popovertarget || namespace_.has_value())
return;
// 2. Set element's explicitly set attr-elements to null.
m_popover_target_element = nullptr;
}
void PopoverInvokerElement::visit_edges(JS::Cell::Visitor& visitor)
{
visitor.visit(m_popover_target_element);
}
}

6
Libraries/LibWeb/HTML/PopoverInvokerElement.h
View file

@ -22,10 +22,8 @@ public:
void set_popover_target_element(GC::Ptr<DOM::Element> value) { m_popover_target_element = value; }
protected:
void visit_edges(JS::Cell::Visitor& visitor)
{
visitor.visit(m_popover_target_element);
}
void visit_edges(JS::Cell::Visitor&);
void associated_attribute_changed(FlyString const& name, Optional<String> const& value, Optional<FlyString> const& namespace_);
private:
GC::Ptr<DOM::Element> m_popover_target_element;