mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-20 09:21:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibCrypto: Use ASN1 macros for EC key parsing

Browse source 
Improve error handling in `EC::parse_ec_key` by using ASN1 macros and
generalizing the parsing to both private and public keys.
This commit is contained in:
devgianlu 2024-11-29 18:20:24 +01:00 • committed by Andreas Kling
commit 0280838944
Notes: github-actions[bot] 2024-11-30 10:19:02 +00:00
3 changed files with 92 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibCrypto/Certificate/Certificate.cpp
View file

@ -395,9 +395,9 @@ ErrorOr<PrivateKey> parse_private_key_info(Crypto::ASN1::Decoder& decoder, Vecto
return private_key;
}
if (private_key.algorithm.identifier.span() == ASN1::ec_public_key_encryption_oid.span()) {
auto maybe_key = Crypto::PK::EC::parse_ec_key(value.bytes());
auto maybe_key = Crypto::PK::EC::parse_ec_key(value.bytes(), true, current_scope);
if (maybe_key.is_error()) {
ERROR_WITH_SCOPE(TRY(String::formatted("Invalid EC key at {}: {}", current_scope, maybe_key.release_error())));
ERROR_WITH_SCOPE(maybe_key.release_error());
}
private_key.ec = move(maybe_key.release_value().private_key);