mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-05-28 14:02:51 +00:00
Kernel/Graphics: Be more consistent about arguments passing
This fixes a bug that was reported on this discord server by @ElectrodeYT - due to the confusion of passing arguments in different orders, we messed up and triggered a page fault due to faulty sizes.
This commit is contained in:
parent
ca9101e5f0
commit
02b73cb93d
Notes:
sideshowbarker
2024-07-18 17:58:27 +09:00
Author: https://github.com/supercomputer7
Commit: 02b73cb93d
Pull-request: https://github.com/SerenityOS/serenity/pull/7198
8 changed files with 18 additions and 18 deletions
|
@ -14,13 +14,13 @@
|
|||
namespace Kernel::Graphics {
|
||||
class FramebufferConsole final : public Console {
|
||||
public:
|
||||
static NonnullRefPtr<FramebufferConsole> initialize(PhysicalAddress, size_t width, size_t height, size_t bpp);
|
||||
static NonnullRefPtr<FramebufferConsole> initialize(PhysicalAddress, size_t width, size_t height, size_t pitch);
|
||||
|
||||
virtual size_t bytes_per_base_glyph() const override;
|
||||
virtual size_t chars_per_line() const override;
|
||||
|
||||
virtual size_t max_column() const { return m_width / 8; }
|
||||
virtual size_t max_row() const { return m_height / 8; }
|
||||
virtual size_t max_column() const override { return m_width / 8; }
|
||||
virtual size_t max_row() const override { return m_height / 8; }
|
||||
|
||||
virtual bool is_hardware_paged_capable() const override { return false; }
|
||||
virtual bool has_hardware_cursor() const override { return false; }
|
||||
|
@ -41,7 +41,7 @@ public:
|
|||
|
||||
protected:
|
||||
void clear_glyph(size_t x, size_t y) const;
|
||||
FramebufferConsole(PhysicalAddress, size_t width, size_t height, size_t bpp);
|
||||
FramebufferConsole(PhysicalAddress, size_t width, size_t height, size_t pitch);
|
||||
OwnPtr<Region> m_framebuffer_region;
|
||||
PhysicalAddress m_framebuffer_address;
|
||||
size_t m_pitch;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue